You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2009/12/23 12:39:53 UTC
svn commit: r893479 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung
Date: Wed Dec 23 11:39:53 2009
New Revision: 893479
URL: http://svn.apache.org/viewvc?rev=893479&view=rev
Log:
Vote and comment.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=893479&r1=893478&r2=893479&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Dec 23 11:39:53 2009
@@ -266,7 +266,7 @@
* Log threads that are started but not stopped by web applications
http://svn.apache.org/viewvc?view=revision&revision=885241
http://svn.apache.org/viewvc?view=revision&revision=885260
- +1: markt, jim
+ +1: markt, jim, rjung
-1:
* More memory leak protection: ThreadLocals, RMI references, optionally stopping
@@ -275,9 +275,6 @@
http://svn.apache.org/viewvc?view=revision&revision=892843
+1: markt, jim
-1:
- rjung: I added the second commit after Mark proposed and votes. It is
- a comment typo change only. Will need more time to vote on
- the whole proposal though.
* Fix second part of https://issues.apache.org/bugzilla/show_bug.cgi?id=47413#c8
Coerce result of composite EL expression (${a}${b}) from String to the expected type.
@@ -296,3 +293,10 @@
http://people.apache.org/~jfclere/patches/patch.20091223
+1: jfclere, kkolinko, markt
-1:
+ rjung: I'm confused now, which of the three proposals are still relevant.
+ I'm +0 for jfc's proposal.
+ One question before going +1: where does '*' as a filename prefix
+ come from? If we generate the format output by "md5sum", then
+ everyone can easily check with "md5sum -c". For this we would need
+ to use ' ' (two spaces) instead of ' *' as a separator between md5
+ and file name.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r893479 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Rainer Jung <ra...@kippdata.de>.
On 23.12.2009 13:10, Mark Thomas wrote:
> On 23/12/2009 11:39, rjung@apache.org wrote:
>> + One question before going +1: where does '*' as a filename prefix
>> + come from?
> man mdssum
Thanks! I thought it came from simulating some alternative ant way of
doing things.
As you said, all files are binary in the sense of what md5sum thinks is
a binary: when you create an md5 with md5sum without flags on Unix it
usually won't put the '*' there, but you can convince it to add the '*'
by using the "-b" flag. Looks like it's useful for Windows when to
decide whether to open the file in text or binary mode during checking
the md5.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r893479 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 23/12/2009 11:39, rjung@apache.org wrote:
> Author: rjung
> Date: Wed Dec 23 11:39:53 2009
> New Revision: 893479
>
> URL: http://svn.apache.org/viewvc?rev=893479&view=rev
> Log:
> Vote and comment.
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
>
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=893479&r1=893478&r2=893479&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Dec 23 11:39:53 2009
> @@ -266,7 +266,7 @@
> * Log threads that are started but not stopped by web applications
> http://svn.apache.org/viewvc?view=revision&revision=885241
> http://svn.apache.org/viewvc?view=revision&revision=885260
> - +1: markt, jim
> + +1: markt, jim, rjung
> -1:
>
> * More memory leak protection: ThreadLocals, RMI references, optionally stopping
> @@ -275,9 +275,6 @@
> http://svn.apache.org/viewvc?view=revision&revision=892843
> +1: markt, jim
> -1:
> - rjung: I added the second commit after Mark proposed and votes. It is
> - a comment typo change only. Will need more time to vote on
> - the whole proposal though.
>
> * Fix second part of https://issues.apache.org/bugzilla/show_bug.cgi?id=47413#c8
> Coerce result of composite EL expression (${a}${b}) from String to the expected type.
> @@ -296,3 +293,10 @@
> http://people.apache.org/~jfclere/patches/patch.20091223
> +1: jfclere, kkolinko, markt
> -1:
> + rjung: I'm confused now, which of the three proposals are still relevant.
> + I'm +0 for jfc's proposal.
AFAICT, JFC's patch is a port of Konstantin's patches that won't apply
cleanly to 6.0.x
> + One question before going +1: where does '*' as a filename prefix
> + come from?
man mdssum
> + If we generate the format output by "md5sum", then
> + everyone can easily check with "md5sum -c". For this we would need
> + to use ' ' (two spaces) instead of ' *' as a separator between md5
> + and file name.
-1. As per the manual, '*' indicates binary files, ' ' indicates text
files. These are all binary.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org