You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2023/07/04 09:38:04 UTC
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20157
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
[multi-tenancy] standardize the use of tenant's api
In order to standardize the use of tenants, in this patch,
I changed the defining parameter of multiple tenant-related
APIs from the tenant name to the tenant ID. In the future,
the update of tenant names will be supported and modification
of tenant IDs will be prohibited.
Since there are no logical changes involved, no new unit tests
have been added.
Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
---
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
7 files changed, 56 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/20157/1
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20157
to look at the new patch set (#2).
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
[multi-tenancy] standardize the use of tenant's api
In order to standardize the use of tenants, in this patch,
I changed the defining parameter of multiple tenant-related
APIs from the tenant name to the tenant ID. In the future,
the update of tenant names will be supported and modification
of tenant IDs will be prohibited.
Since there are no logical changes involved, no new unit tests
have been added.
Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
---
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
7 files changed, 56 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/20157/2
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20157 )
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
[multi-tenancy] standardize the use of tenant's api
In order to standardize the use of tenants, in this patch,
I changed the defining parameter of multiple tenant-related
APIs from the tenant name to the tenant ID. In the future,
the update of tenant names will be supported and modification
of tenant IDs will be prohibited.
Since there are no logical changes involved, no new unit tests
have been added.
Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Reviewed-on: http://gerrit.cloudera.org:8080/20157
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
7 files changed, 56 insertions(+), 55 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20157 )
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 05 Jul 2023 06:06:04 +0000
Gerrit-HasComments: No
[kudu-CR] [multi-tenancy] standardize the use of tenant's api
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20157 )
Change subject: [multi-tenancy] standardize the use of tenant's api
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8c09668456bc1147d8e269ecaa8e616798d2c7
Gerrit-Change-Number: 20157
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 09:55:18 +0000
Gerrit-HasComments: No