You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Eric Chung <ci...@gmail.com> on 2017/08/03 20:45:37 UTC
Re: Review Request 61172: Added mesos.http and mesos.exceptions for
CLI.
> On July 29, 2017, 3:12 p.m., Armand Grillet wrote:
> > In _testing done_, there seems to be a missing first part asking to run the updated bootstrap script and `source activate` under `src/python/cli_new` before running `tox`. At least these were necessary steps for me to have `tox` running correctly.
hmm that's weird. can you try again with a clean checkout? what were the errors that you saw?
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review181756
-----------------------------------------------------------
On July 27, 2017, 7:09 a.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61172/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 7:09 a.m.)
>
>
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mesos.http and mesos.exceptions for CLI.
>
> Part of MESOS-7310, This patch adds the mesos.http and mesos.exceptions modules, which provides a `Resource` class and its descendants for abstracting away common operations over http connectioins with JSON serialization.
>
>
> Diffs
> -----
>
> src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442
> src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818
> src/python/lib/mesos/exceptions.py PRE-CREATION
> src/python/lib/mesos/http.py PRE-CREATION
> src/python/lib/requirements.in e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> src/python/lib/tests/conftest.py PRE-CREATION
> src/python/lib/tests/test_exceptions.py PRE-CREATION
> src/python/lib/tests/test_http.py PRE-CREATION
> src/python/lib/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054
>
>
> Diff: https://reviews.apache.org/r/61172/diff/1/
>
>
> Testing
> -------
>
> under src/python/lib, call `tox` for running unit tests. The test should pass and test coverage should be at 100%.
>
>
> Thanks,
>
> Eric Chung
>
>