[GitHub] [arrow] icexelloss commented on a diff in pull request #35514: GH-35515: [C++][Python] Add non decomposable aggregation UDF

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #35514:
URL: https://github.com/apache/arrow/pull/35514#discussion_r1196661499


##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -954,7 +954,9 @@ ExtensionIdRegistry::SubstraitAggregateToArrow DecodeBasicAggregate(
         return Status::Invalid("Expected aggregate call ", call.id().uri, "#",
                                call.id().name, " to have at least one argument");
       }
-      case 1: {
+      default: {

Review Comment:
   This is so that we can support UDFs which can have arity > 1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org