[GitHub] [nifi] mark-bathori commented on pull request #7777: NIFI-11177: Add defensive code for null values for Iceberg

["mark-bathori (via GitHub)" <gi...@apache.org>]

mark-bathori commented on PR #7777:
URL: https://github.com/apache/nifi/pull/7777#issuecomment-1732620850

   I think the last commit is not needed since the original solution contains null check in every `convert` implementation, so we have 2 options here:
   
   1. Add null check in every `convert` method implementation, so the `convertWithNullCheck` is not needed.
   2. Use the `convertWithNullCheck`, make the original `convert` method private and remove the null checks from the implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org