You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@karaf.apache.org by ld...@apache.org on 2011/01/27 15:40:05 UTC

svn commit: r1064135 - /karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java

Author: ldywicki
Date: Thu Jan 27 14:40:05 2011
New Revision: 1064135

URL: http://svn.apache.org/viewvc?rev=1064135&view=rev
Log:
KARAF-421 Refactor previous patch to avoid performance issues (recreating TreeSet at every completer call).

Modified:
    karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java

Modified: karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java?rev=1064135&r1=1064134&r2=1064135&view=diff
==============================================================================
--- karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java (original)
+++ karaf/branches/karaf-2.1.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/StringsCompleter.java Thu Jan 27 14:40:05 2011
@@ -48,7 +48,7 @@ public class StringsCompleter
         this(Arrays.asList(strings));
     }
 
-    public Collection<String> getStrings() {
+    public SortedSet<String> getStrings() {
         return strings;
     }
 
@@ -61,7 +61,7 @@ public class StringsCompleter
         }
 
         // KARAF-421, use getStrings() instead strings field.
-        SortedSet<String> matches = new TreeSet<String>(getStrings()).tailSet(buffer);
+        SortedSet<String> matches = getStrings().tailSet(buffer);
 
         for (String match : matches) {
             if (!match.startsWith(buffer)) {