You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2014/07/15 01:01:53 UTC

[06/10] git commit: TS-1475: Coverity 1021842 - fix resource leak

TS-1475: Coverity 1021842 - fix resource leak


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/cc30284b
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/cc30284b
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/cc30284b

Branch: refs/heads/master
Commit: cc30284b18c6be67596bd7ef4acd94e6fa846fc9
Parents: 0c7fa24
Author: Justin Laue <ju...@fp-x.com>
Authored: Mon Jul 14 16:31:37 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Mon Jul 14 17:01:40 2014 -0600

----------------------------------------------------------------------
 iocore/cache/Cache.cc | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cc30284b/iocore/cache/Cache.cc
----------------------------------------------------------------------
diff --git a/iocore/cache/Cache.cc b/iocore/cache/Cache.cc
index f485d0d..333294c 100644
--- a/iocore/cache/Cache.cc
+++ b/iocore/cache/Cache.cc
@@ -750,6 +750,7 @@ CacheProcessor::start_internal(int flags)
 #else
         gdisks[gndisks]->open(path, blocks, skip, sector_size, fd, clear);
 #endif
+        fd = 0;
         gndisks++;
       }
     } else {
@@ -758,6 +759,9 @@ CacheProcessor::start_internal(int flags)
       else
         Warning("cache unable to open '%s': %s", path, strerror(errno));
     }
+    if(fd > 0) {
+    	close(fd);
+    }
   }
 
   if (gndisks == 0) {