You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/28 02:37:31 UTC

[GitHub] [apisix-ingress-controller] iamayushdas opened a new pull request #275: updated technical architecture of apisix-ingress-controller

iamayushdas opened a new pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797261233


   Any update? @iamayushdas 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report
   > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (312f16f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.56%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #275      +/-   ##
   ==========================================
   - Coverage   53.85%   52.28%   -1.57%     
   ==========================================
     Files          33       32       -1     
     Lines        2245     2320      +75     
   ==========================================
   + Hits         1209     1213       +4     
   - Misses        879      950      +71     
     Partials      157      157              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: |
   | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `39.86% <0.00%> (+0.40%)` | :arrow_up: |
   | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: |
   | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `4.00% <0.00%> (+2.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...312f16f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report
   > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (a3dbe63) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #275      +/-   ##
   ==========================================
   - Coverage   53.85%   52.19%   -1.66%     
   ==========================================
     Files          33       33              
     Lines        2245     2320      +75     
   ==========================================
   + Hits         1209     1211       +2     
   - Misses        879      952      +73     
     Partials      157      157              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: |
   | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...a3dbe63](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799295303


   > @gxthrj i have done the change according to helm repo ,can i have a review please?
   
   There are some  conflicting files need to be due with.
   Some docs has been modify by https://github.com/apache/apisix-ingress-controller/pull/283.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584440389



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       Here is the ingress-controller architecture diagram, which introduces the role of ingress-controller and its deployment position in Kubernetes, not the division of modules.
   
   I suggest refer to this [issue](https://github.com/apache/apisix-ingress-controller/issues/274) to modify the image.
   
   Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799303127


   What to do now? Should i close the PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797264551


   Not till now. I am having issues in understanding 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797270041


   > Not till now. I am having issues in understanding
   
   what is the problem?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584308912



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       What else i was supposed to do? Can you please elaborate?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584309058



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       Do i have to remove the previous architecture diagram and replace with new one using “module-0” name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r587094436



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,7 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
 helm dependency update ./charts/apisix

Review comment:
       Since we use helm repo, It is recommended to modify like this.
   ```suggestion
   helm search repo apisix
   helm repo update
   helm install apisix apisix/apisix \
     --set ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r587080932



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,7 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       > should not still use the local apisix, instead, use the online repo.
   
   I have done the same as you said, isn't so?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r586155688



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       We are writing them and will push them to GitHub as soon as possible :)
   Also, Would you like to use this [image](https://user-images.githubusercontent.com/6814606/109374178-521b4300-78ee-11eb-8315-4da896383f53.png) to replace the current one? It's more clear (though it's a high level interpretation).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244


   @gxthrj  i have done the change according to helm repo ,can i have a review please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report
   > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (0ed3156) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **increase** coverage by `46.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##           master      #275       +/-   ##
   ============================================
   + Coverage   53.85%   100.00%   +46.14%     
   ============================================
     Files          33         1       -32     
     Lines        2245         1     -2244     
   ============================================
   - Hits         1209         1     -1208     
   + Misses        879         0      -879     
   + Partials      157         0      -157     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | | |
   | [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
   | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | | |
   | [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | | |
   | [pkg/id/idgen.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2lkL2lkZ2VuLmdv) | | |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | | |
   | [pkg/seven/conf/conf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2NvbmYvY29uZi5nbw==) | | |
   | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | |
   | [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | | |
   | ... and [22 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...0ed3156](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-789575611


   Review please! @gxthrj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584508248



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       where can i understand and know the latest architecture? @tokers 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r586459887



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,7 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       should not still use the local apisix, instead, use the online repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report
   > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (a3dbe63) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #275      +/-   ##
   ==========================================
   - Coverage   53.85%   52.17%   -1.68%     
   ==========================================
     Files          33       32       -1     
     Lines        2245     2319      +74     
   ==========================================
   + Hits         1209     1210       +1     
   - Misses        879      952      +73     
     Partials      157      157              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: |
   | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...a3dbe63](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584307864



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       Excuse me, I found the `./docs/assets/images/module_0.png` in your branch is the [pic in design](https://github.com/apache/apisix-ingress-controller/blob/master/docs/assets/images/modules.png), but why ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas closed pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r584485770



##########
File path: README.md
##########
@@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR
 
 The technical architecture of `apisix-ingress-controller`:
 
-<img src="./docs/assets/images/module-0.png" alt="Architecture" width="600" height="313" />
+<img src="./docs/assets/images/module_0.png" alt="Architecture" width="600" height="313" />

Review comment:
       Actually now the internal of apisix-ingress-controller has some changes, the diagram cannot reflect the real situation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799381483


   @iamayushdas The helm charts part was fixed by another one, I think now you should merge from the master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #275:
URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244


   @gxthrj can i have a review on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org