You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/14 17:23:06 UTC
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2252
[ZEPPELIN-1940] lint rule set is NOT applied at all.
### What is this PR for?
eslint ruleset is NOT applied at all due to invalid `.eslintrc`.
This PR includes
- fixes which is automatically done by eslint (`eslint --fix src`)
- modification in `.eslintrc`, `package.json`
- while removing eslint conf in `gruntfile.js`
As a result of this PR, we can have more strict and modernized rulesets which can help us to prevent bugs.
### What type of PR is it?
[Improvement]
### Todos
* [x] - Setup rules
* [x] - Remove grunt eslint config
* [x] - Ignore useless rules
* [x] - Fix code for applied rules
### What is the Jira issue?
[ZEPPELIN-1940](https://issues.apache.org/jira/browse/ZEPPELIN-1940)
### How should this be tested?
- `cd zeppelin-web`
- `npm run lint:once`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1940/apply-lint-rule-set
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2252
----
commit fcf7569c0b3eb2bbccb33ce531cee33e8ffdd950
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T00:40:25Z
fix: Use eslint instead of grunt-eslint
commit 1ee0af31976c2d104fedb9c00345ea0201a6eda1
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T00:40:51Z
fix: Remove invalid visdev
commit ff30ff0864c6dae7eff21f959b084176a6f6ac21
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:08:06Z
fix: Set ignored, warn lint rules
commit 2d80425af198beab28754e57cc467a9aed0e2818
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:19:51Z
fix: ignore all rules
commit 065801aad09160e69f12ea21ed3f449898b2beb5
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:24:15Z
fix: yoda
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/handsontable/handsonHelper.js
160:49 error Expected literal to be on the right side of === yoda
```
commit 1f1862f74f41a981dbc5ec805dc690b9c993f7b9
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:25:44Z
fix: no-mixed-spaces-and-tabs
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js (3/0)
\u2716 79:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
\u2716 80:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
\u2716 81:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
```
commit 139b28d96883b4056df8fce3a5ddd979900fae4e
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:27:18Z
fix: semi-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js (1/0)
\u2716 20:26 Unexpected whitespace before semicolon semi-spacing
```
commit deb679cd282db0e40c488a0ae2c31a5dca37f77c
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:31:05Z
fix: no-extra-boolean-cast
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/app.js (1/0)
\u2716 40:12 Redundant double negation no-extra-boolean-cast
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/jobmanager/jobs/job.controller.js (2/0)
\u2716 58:18 Redundant double negation no-extra-boolean-cast
\u2716 90:18 Redundant double negation no-extra-boolean-cast
```
commit 8b540e230802490807f1d938baa30f4a3c75c727
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:35:15Z
fix: object-property-newline
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (7/0)
\u2716 45:26 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 46:24 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 46:40 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 71:38 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 76:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 89:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 102:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (0/2)
\u26a0 132:37 Unexpected mix of '&&' and '||' no-mixed-operators
\u26a0 132:54 Unexpected mix of '&&' and '||' no-mixed-operators
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium-conf.js (3/0)
\u2716 34:19 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 34:41 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 35:21 Object properties must go on a new line if they aren't all on the same line object-property-newline
```
commit 685878446dcce8c7134f46c8a489085e4c927fd2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:38:50Z
fix: dot-location
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/configuration/configuration.controller.js (2/0)
\u2716 25:67 Expected dot to be on same line as property dot-location
\u2716 28:7 Expected dot to be on same line as property dot-location
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/credential/credential.controller.js (8/0)
\u2716 28:59 Expected dot to be on same line as property dot-location
\u2716 34:7 Expected dot to be on same line as property dot-location
\u2716 67:74 Expected dot to be on same line as property dot-location
\u2716 78:7 Expected dot to be on same line as property dot-location
\u2716 142:69 Expected dot to be on same line as property dot-location
\u2716 147:7 Expected dot to be on same line as property dot-location
\u2716 169:78 Expected dot to be on same line as property dot-location
\u2716 174:13 Expected dot to be on same line as property dot-location
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (4/0)
\u2716 135:73 Expected dot to be on same line as property dot-location
\u2716 139:13 Expected dot to be on same line as property dot-location
\u2716 262:38 Expected dot to be on same line as property dot-location
\u2716 266:13 Expected dot to be on same line as property dot-location
```
commit fc09077291e178b097ace416eeb2b5bcfe571a28
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:41:30Z
fix: brace-style
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (1/0)
\u2716 67:39 Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 228:66 Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
```
commit ea787650f4c0afddc998be05524886e576ea8432
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:43:24Z
fix: one-var
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 210:7 Split initialized 'var' declarations into multiple statements one-var
```
commit 721243ae39e76fda92898ddcb659c5ec30d2d720
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:45:06Z
fix: no-multi-spaces
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js (4/0)
\u2716 403:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 415:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 437:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 715:28 Multiple spaces found before '(' no-multi-spaces
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/tabledata/pivot.js (1/0)
\u2716 247:49 Multiple spaces found before 'p' no-multi-spaces
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 271:42 Multiple spaces found before '','' no-multi-spaces
```
commit 4f0391dba7057f3db38040c68788309e7ca53745
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:46:51Z
fix: no-empty
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (1/2)
\u2716 52:25 Empty block statement no-empty
```
commit b1613fc0ce499b415af7f066c29e573cae2fb94a
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:48:21Z
fix: space-in-parens
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (7/0)
\u2716 212:10 There should be no spaces inside this paren space-in-parens
\u2716 212:18 There should be no spaces inside this paren space-in-parens
\u2716 215:10 There should be no spaces inside this paren space-in-parens
\u2716 215:18 There should be no spaces inside this paren space-in-parens
\u2716 232:47 There should be no spaces inside this paren space-in-parens
\u2716 233:10 There should be no spaces inside this paren space-in-parens
\u2716 234:74 There should be no spaces inside this paren space-in-parens
```
commit 303863554feb2fc37466e831cb32514a95bb2a11
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:49:31Z
fix: keyword-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js (1/0)
\u2716 335:11 Expected space(s) after "for" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/spell/spell-result.js (1/0)
\u2716 90:5 Expected space(s) after "for" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 236:9 Expected space(s) after "else" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium-conf.js (2/0)
\u2716 28:3 Expected space(s) after "for" keyword-spacing
\u2716 80:5 Expected space(s) after "catch" keyword-spacing
```
commit 6fee1dede56dfbf6542e0db713c0c264fe980b9a
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:52:51Z
fix: space-before-blocks
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (6/0)
\u2716 81:30 Missing space before opening brace space-before-blocks
\u2716 212:17 Missing space before opening brace space-before-blocks
\u2716 215:17 Missing space before opening brace space-before-blocks
\u2716 228:33 Missing space before opening brace space-before-blocks
\u2716 232:47 Missing space before opening brace space-before-blocks
\u2716 234:74 Missing space before opening brace space-before-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/navbar/navbar.controller.js (1/0)
\u2716 84:25 Missing space before opening brace space-before-blocks
```
commit a54f85604a067a63bf789e24d3803641a79ebe70
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:55:33Z
fix: block-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js (2/0)
\u2716 148:42 Requires a space after '{' block-spacing
\u2716 148:68 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js (4/0)
\u2716 61:40 Requires a space after '{' block-spacing
\u2716 61:86 Requires a space before '}' block-spacing
\u2716 62:40 Requires a space after '{' block-spacing
\u2716 62:72 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js (2/0)
\u2716 61:40 Requires a space after '{' block-spacing
\u2716 61:72 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js (2/0)
\u2716 71:40 Requires a space after '{' block-spacing
\u2716 71:86 Requires a space before '}' block-spacing
```
commit e7f21d242ea5adc84b3d684892f9171a40922315
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:56:55Z
fix: operator-linebreak
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (1/0)
\u2716 324:78 '?' should be placed at the beginning of the line operator-linebreak
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (1/0)
\u2716 1263:71 '?' should be placed at the beginning of the line operator-linebreak
```
commit 638daee153ae61351b420e9a9cdcbad963267df0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:58:19Z
fix: comma-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/tabledata/pivot.js (2/0)
\u2716 151:29 A space is required after ',' comma-spacing
\u2716 156:29 A space is required after ',' comma-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (1/2)
\u2716 96:35 A space is required after ',' comma-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (2/0)
\u2716 228:30 A space is required after ',' comma-spacing
\u2716 235:32 A space is required after ',' comma-spacing
```
commit 4af2a01d6451a929b63f54ad468241902b5ec5c3
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:59:45Z
fix: spaced-comment
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/navbar/navbar.controller.js (2/0)
\u2716 91:5 Expected space or tab after '//' in comment spaced-comment
\u2716 94:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/ngenter/ngenter.directive.test.js (2/0)
\u2716 19:3 Expected space or tab after '//' in comment spaced-comment
\u2716 20:3 Expected space or tab before '*/' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.js (1/0)
\u2716 102:5 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-import/notenameImport.controller.js (1/0)
\u2716 122:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/saveAs/saveAs.service.js (2/0)
\u2716 34:7 Expected space or tab after '//' in comment spaced-comment
\u2716 35:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/searchService/search.service.js (1/0)
\u2716 23:20 Expected space or tab after '//' in comment spaced-comment
```
commit 6f61bc388b7469fb363737d148f3538a524631e5
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:00:53Z
fix: no-trailing-spaces
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (3/0)
\u2716 44:1 Trailing spaces not allowed no-trailing-spaces
\u2716 48:1 Trailing spaces not allowed no-trailing-spaces
\u2716 111:1 Trailing spaces not allowed no-trailing-spaces
```
commit 631495473b73498f2b0f7ffb6346f4568d1d388b
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:01:52Z
fix: no-multiple-empty-lines
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/resizable/resizable.directive.js (1/0)
\u2716 70:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/saveAs/saveAs.service.js (1/0)
\u2716 52:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/searchService/search.service.js (1/0)
\u2716 34:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js (1/0)
\u2716 196:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js (1/0)
\u2716 341:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
```
commit f9993dc1e030432bd9edc5f1831fc61e257acf73
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:09:08Z
fix: indent
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (7/0)
\u2716 71:7 Expected indentation of 4 spaces but found 6 indent
\u2716 75:7 Expected indentation of 4 spaces but found 6 indent
\u2716 82:6 Expected indentation of 4 spaces but found 5 indent
\u2716 83:7 Expected indentation of 7 spaces but found 6 indent
\u2716 85:7 Expected indentation of 7 spaces but found 6 indent
\u2716 87:4 Expected indentation of 2 spaces but found 3 indent
\u2716 231:12 Expected indentation of 8 spaces but found 11 indent
```
commit 47636d6742c3bfebbfd0105b5d91fe884f09c26c
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:13:36Z
fix: space-before-function-paren
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js (48/0)
\u2716 17:25 Missing space before function parentheses space-before-function-paren
\u2716 22:26 Missing space before function parentheses space-before-function-paren
\u2716 26:29 Missing space before function parentheses space-before-function-paren
\u2716 36:30 Missing space before function parentheses space-before-function-paren
\u2716 40:32 Missing space before function parentheses space-before-function-paren
\u2716 44:26 Missing space before function parentheses space-before-function-paren
\u2716 48:28 Missing space before function parentheses space-before-function-paren
\u2716 52:25 Missing space before function parentheses space-before-function-paren
\u2716 56:25 Missing space before function parentheses space-before-function-paren
\u2716 60:27 Missing space before function parentheses space-before-function-paren
\u2716 64:25 Missing space before function parentheses space-before-function-paren
\u2716 68:24 Missing space before function parentheses space-before-function-paren
```
commit 651c5df4e183a04ed3e7867623a53777ad276abb
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:15:41Z
fix: ignore object-curly-spacing
commit e40edd9ef226a3f603d08a6b918adf9e58e70762
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:16:50Z
fix: ignore arrow-parens
commit 5920acaeff0eb36845db354ff49301cbdc3ffd9d
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:17:52Z
fix: no-extra-semi
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-table.js (5/0)
\u2716 28:4 Unnecessary semicolon no-extra-semi
\u2716 32:4 Unnecessary semicolon no-extra-semi
\u2716 51:4 Unnecessary semicolon no-extra-semi
\u2716 57:4 Unnecessary semicolon no-extra-semi
\u2716 61:4 Unnecessary semicolon no-extra-semi
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/visualization.js (14/0)
\u2716 25:4 Unnecessary semicolon no-extra-semi
\u2716 32:4 Unnecessary semicolon no-extra-semi
\u2716 39:4 Unnecessary semicolon no-extra-semi
\u2716 46:4 Unnecessary semicolon no-extra-semi
\u2716 54:4 Unnecessary semicolon no-extra-semi
\u2716 64:4 Unnecessary semicolon no-extra-semi
\u2716 75:4 Unnecessary semicolon no-extra-semi
\u2716 82:4 Unnecessary semicolon no-extra-semi
\u2716 89:4 Unnecessary semicolon no-extra-semi
\u2716 100:4 Unnecessary semicolon no-extra-semi
\u2716 112:4 Unnecessary semicolon no-extra-semi
\u2716 119:4 Unnecessary semicolon no-extra-semi
\u2716 163:4 Unnecessary semicolon no-extra-semi
\u2716 171:2 Unnecessary semicolon no-extra-semi
```
commit faea17a0d66eaa9c4bcc62eb697285482d2529e9
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:19:16Z
fix: space-infix-ops
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (5/0)
\u2716 70:54 Infix operators must be spaced space-infix-ops
\u2716 74:54 Infix operators must be spaced space-infix-ops
\u2716 229:52 Infix operators must be spaced space-infix-ops
\u2716 230:53 Infix operators must be spaced space-infix-ops
\u2716 231:27 Infix operators must be spaced space-infix-ops
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium.service.js (1/0)
\u2716 108:33 Infix operators must be spaced space-infix-ops
```
commit 829e398066ad05085f5b90eb52f1131aede3c3d4
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:21:52Z
fix: padded-blocks
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.test.js (2/0)
\u2716 1:43 Block must not be padded by blank lines padded-blocks
\u2716 77:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.js (1/0)
\u2716 105:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.test.js (1/0)
\u2716 40:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-import/notenameImport.controller.js (1/0)
\u2716 114:5 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js (1/0)
\u2716 110:5 Block must not be padded by blank lines padded-blocks
```
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
Oh.. Will merge into master right after CI turns into green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2252
[ZEPPELIN-1940] lint rule set is NOT applied at all.
### What is this PR for?
eslint ruleset is NOT applied at all due to invalid `.eslintrc`.
This PR includes
- fixes which are automatically done by eslint (`eslint --fix src`)
- modification in `.eslintrc`, `package.json`
- while removing eslint conf in `gruntfile.js`
As a result of this PR, we can have more strict and modernized rulesets which can help us to prevent bugs.
### What type of PR is it?
[Improvement]
### Todos
* [x] - Setup rules
* [x] - Remove grunt eslint config
* [x] - Ignore useless rules
* [x] - Fix code for applied rules
### What is the Jira issue?
[ZEPPELIN-1940](https://issues.apache.org/jira/browse/ZEPPELIN-1940)
### How should this be tested?
- `cd zeppelin-web`
- `npm install` (or `yarn install` if you have yarn)
- `npm run lint:once`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1940/apply-lint-rule-set
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2252
----
commit 4baadbb0aa8c312a0090ce3b00ae9aa5d57a24d0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T00:40:25Z
fix: Use eslint instead of grunt-eslint
commit 55669118889943a634fec4e2ca1d20f6de5dfdb0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T00:40:51Z
fix: Remove invalid visdev
commit 7840ca5fa7b38e9a28117dcc8bf12f7bf299b824
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:08:06Z
fix: Set ignored, warn lint rules
commit 4b36afb2fa6e6ef2afd3388e2fcfd48754d731d2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:19:51Z
fix: ignore all rules
commit 8d5a3d9dfb677e98d06b0d46321142e6cfe5f68d
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:24:15Z
fix: yoda
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/handsontable/handsonHelper.js
160:49 error Expected literal to be on the right side of === yoda
```
commit 3abfc7c3f3febe06d2ee11c80801005d32770d82
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:25:44Z
fix: no-mixed-spaces-and-tabs
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js (3/0)
\u2716 79:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
\u2716 80:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
\u2716 81:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
```
commit a5c7842d4f9d54697d81ef666d9e8991e3b5fd7a
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:27:18Z
fix: semi-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js (1/0)
\u2716 20:26 Unexpected whitespace before semicolon semi-spacing
```
commit 70cb63b742cb310f8ccaff56ad68cff9ec8dce40
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:31:05Z
fix: no-extra-boolean-cast
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/app.js (1/0)
\u2716 40:12 Redundant double negation no-extra-boolean-cast
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/jobmanager/jobs/job.controller.js (2/0)
\u2716 58:18 Redundant double negation no-extra-boolean-cast
\u2716 90:18 Redundant double negation no-extra-boolean-cast
```
commit d62af8d31b3d8315a4b03b02e5b349edcdbb11c3
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:35:15Z
fix: object-property-newline
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (7/0)
\u2716 45:26 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 46:24 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 46:40 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 71:38 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 76:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 89:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 102:36 Object properties must go on a new line if they aren't all on the same line object-property-newline
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (0/2)
\u26a0 132:37 Unexpected mix of '&&' and '||' no-mixed-operators
\u26a0 132:54 Unexpected mix of '&&' and '||' no-mixed-operators
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium-conf.js (3/0)
\u2716 34:19 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 34:41 Object properties must go on a new line if they aren't all on the same line object-property-newline
\u2716 35:21 Object properties must go on a new line if they aren't all on the same line object-property-newline
```
commit cde8a2d2d24ec045ea7bf86385f1e73b0a8419e9
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:38:50Z
fix: dot-location
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/configuration/configuration.controller.js (2/0)
\u2716 25:67 Expected dot to be on same line as property dot-location
\u2716 28:7 Expected dot to be on same line as property dot-location
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/credential/credential.controller.js (8/0)
\u2716 28:59 Expected dot to be on same line as property dot-location
\u2716 34:7 Expected dot to be on same line as property dot-location
\u2716 67:74 Expected dot to be on same line as property dot-location
\u2716 78:7 Expected dot to be on same line as property dot-location
\u2716 142:69 Expected dot to be on same line as property dot-location
\u2716 147:7 Expected dot to be on same line as property dot-location
\u2716 169:78 Expected dot to be on same line as property dot-location
\u2716 174:13 Expected dot to be on same line as property dot-location
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (4/0)
\u2716 135:73 Expected dot to be on same line as property dot-location
\u2716 139:13 Expected dot to be on same line as property dot-location
\u2716 262:38 Expected dot to be on same line as property dot-location
\u2716 266:13 Expected dot to be on same line as property dot-location
```
commit 7aa4b1aae69c4899a748ba45ac511ac365ecd0b1
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:41:30Z
fix: brace-style
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (1/0)
\u2716 67:39 Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 228:66 Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
```
commit 1de9a8d2f87345175ae963787df8490766c277f2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:43:24Z
fix: one-var
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 210:7 Split initialized 'var' declarations into multiple statements one-var
```
commit 131c901d47f030d8dd349b8fb555a98f97a788b4
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:45:06Z
fix: no-multi-spaces
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js (4/0)
\u2716 403:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 415:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 437:21 Multiple spaces found before 'elem' no-multi-spaces
\u2716 715:28 Multiple spaces found before '(' no-multi-spaces
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/tabledata/pivot.js (1/0)
\u2716 247:49 Multiple spaces found before 'p' no-multi-spaces
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 271:42 Multiple spaces found before '','' no-multi-spaces
```
commit b094fff553f409f830c848bc89531bf199e9abbd
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:46:51Z
fix: no-empty
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (1/2)
\u2716 52:25 Empty block statement no-empty
```
commit 5948d97aa92fd06095485c79211a13d6530940f9
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:48:21Z
fix: space-in-parens
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (7/0)
\u2716 212:10 There should be no spaces inside this paren space-in-parens
\u2716 212:18 There should be no spaces inside this paren space-in-parens
\u2716 215:10 There should be no spaces inside this paren space-in-parens
\u2716 215:18 There should be no spaces inside this paren space-in-parens
\u2716 232:47 There should be no spaces inside this paren space-in-parens
\u2716 233:10 There should be no spaces inside this paren space-in-parens
\u2716 234:74 There should be no spaces inside this paren space-in-parens
```
commit a896442c2498c2d20e7fcdb6875cbe2134fcd03e
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:49:31Z
fix: keyword-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js (1/0)
\u2716 335:11 Expected space(s) after "for" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/spell/spell-result.js (1/0)
\u2716 90:5 Expected space(s) after "for" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (1/0)
\u2716 236:9 Expected space(s) after "else" keyword-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium-conf.js (2/0)
\u2716 28:3 Expected space(s) after "for" keyword-spacing
\u2716 80:5 Expected space(s) after "catch" keyword-spacing
```
commit 021f9e761c2f2bd10c5e77ddca8910a9ed4ccb8c
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:52:51Z
fix: space-before-blocks
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (6/0)
\u2716 81:30 Missing space before opening brace space-before-blocks
\u2716 212:17 Missing space before opening brace space-before-blocks
\u2716 215:17 Missing space before opening brace space-before-blocks
\u2716 228:33 Missing space before opening brace space-before-blocks
\u2716 232:47 Missing space before opening brace space-before-blocks
\u2716 234:74 Missing space before opening brace space-before-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/navbar/navbar.controller.js (1/0)
\u2716 84:25 Missing space before opening brace space-before-blocks
```
commit 925dc7be6b1d7b5a5a1f732691deac6a3fa40d54
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:55:33Z
fix: block-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js (2/0)
\u2716 148:42 Requires a space after '{' block-spacing
\u2716 148:68 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js (4/0)
\u2716 61:40 Requires a space after '{' block-spacing
\u2716 61:86 Requires a space before '}' block-spacing
\u2716 62:40 Requires a space after '{' block-spacing
\u2716 62:72 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js (2/0)
\u2716 61:40 Requires a space after '{' block-spacing
\u2716 61:72 Requires a space before '}' block-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js (2/0)
\u2716 71:40 Requires a space after '{' block-spacing
\u2716 71:86 Requires a space before '}' block-spacing
```
commit 9150539175fabccb8bc0242ee14bc0ce82cd200d
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:56:55Z
fix: operator-linebreak
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (1/0)
\u2716 324:78 '?' should be placed at the beginning of the line operator-linebreak
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (1/0)
\u2716 1263:71 '?' should be placed at the beginning of the line operator-linebreak
```
commit d65c47bb428ae24b303e4768474cad644dbfc1dd
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:58:19Z
fix: comma-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/tabledata/pivot.js (2/0)
\u2716 151:29 A space is required after ',' comma-spacing
\u2716 156:29 A space is required after ',' comma-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js (1/2)
\u2716 96:35 A space is required after ',' comma-spacing
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (2/0)
\u2716 228:30 A space is required after ',' comma-spacing
\u2716 235:32 A space is required after ',' comma-spacing
```
commit ca943418262ff55bbe6d3fb4640d15f7ab9c3775
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T15:59:45Z
fix: spaced-comment
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/navbar/navbar.controller.js (2/0)
\u2716 91:5 Expected space or tab after '//' in comment spaced-comment
\u2716 94:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/ngenter/ngenter.directive.test.js (2/0)
\u2716 19:3 Expected space or tab after '//' in comment spaced-comment
\u2716 20:3 Expected space or tab before '*/' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.js (1/0)
\u2716 102:5 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-import/notenameImport.controller.js (1/0)
\u2716 122:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/saveAs/saveAs.service.js (2/0)
\u2716 34:7 Expected space or tab after '//' in comment spaced-comment
\u2716 35:7 Expected space or tab after '//' in comment spaced-comment
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/searchService/search.service.js (1/0)
\u2716 23:20 Expected space or tab after '//' in comment spaced-comment
```
commit 3a6626f0d274d2bb767c42256fb5d5ba77addf16
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:00:53Z
fix: no-trailing-spaces
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/helium/helium.controller.js (3/0)
\u2716 44:1 Trailing spaces not allowed no-trailing-spaces
\u2716 48:1 Trailing spaces not allowed no-trailing-spaces
\u2716 111:1 Trailing spaces not allowed no-trailing-spaces
```
commit 40125e95c8a6a4979b23e1601bc30c003f6cc9cf
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:01:52Z
fix: no-multiple-empty-lines
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/resizable/resizable.directive.js (1/0)
\u2716 70:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/saveAs/saveAs.service.js (1/0)
\u2716 52:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/searchService/search.service.js (1/0)
\u2716 34:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js (1/0)
\u2716 196:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js (1/0)
\u2716 341:1 Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
```
commit 59c3996f82e158a62e255e17bea9157ad475c472
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:09:08Z
fix: indent
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (7/0)
\u2716 71:7 Expected indentation of 4 spaces but found 6 indent
\u2716 75:7 Expected indentation of 4 spaces but found 6 indent
\u2716 82:6 Expected indentation of 4 spaces but found 5 indent
\u2716 83:7 Expected indentation of 7 spaces but found 6 indent
\u2716 85:7 Expected indentation of 7 spaces but found 6 indent
\u2716 87:4 Expected indentation of 2 spaces but found 3 indent
\u2716 231:12 Expected indentation of 8 spaces but found 11 indent
```
commit 6e44e96de833bb8cdcdfb4ee182cf3cd0bc406f1
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:13:36Z
fix: space-before-function-paren
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js (48/0)
\u2716 17:25 Missing space before function parentheses space-before-function-paren
\u2716 22:26 Missing space before function parentheses space-before-function-paren
\u2716 26:29 Missing space before function parentheses space-before-function-paren
\u2716 36:30 Missing space before function parentheses space-before-function-paren
\u2716 40:32 Missing space before function parentheses space-before-function-paren
\u2716 44:26 Missing space before function parentheses space-before-function-paren
\u2716 48:28 Missing space before function parentheses space-before-function-paren
\u2716 52:25 Missing space before function parentheses space-before-function-paren
\u2716 56:25 Missing space before function parentheses space-before-function-paren
\u2716 60:27 Missing space before function parentheses space-before-function-paren
\u2716 64:25 Missing space before function parentheses space-before-function-paren
\u2716 68:24 Missing space before function parentheses space-before-function-paren
```
commit 3c91566c7c540bdbba4c97290bd8e3ff0f4f2d82
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:15:41Z
fix: ignore object-curly-spacing
commit bfd79849938c385aa209325bd41965ecd81ab8e0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:16:50Z
fix: ignore arrow-parens
commit eac6b438c261bdb94de96a2c42d8428776f4f104
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:17:52Z
fix: no-extra-semi
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-table.js (5/0)
\u2716 28:4 Unnecessary semicolon no-extra-semi
\u2716 32:4 Unnecessary semicolon no-extra-semi
\u2716 51:4 Unnecessary semicolon no-extra-semi
\u2716 57:4 Unnecessary semicolon no-extra-semi
\u2716 61:4 Unnecessary semicolon no-extra-semi
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/visualization.js (14/0)
\u2716 25:4 Unnecessary semicolon no-extra-semi
\u2716 32:4 Unnecessary semicolon no-extra-semi
\u2716 39:4 Unnecessary semicolon no-extra-semi
\u2716 46:4 Unnecessary semicolon no-extra-semi
\u2716 54:4 Unnecessary semicolon no-extra-semi
\u2716 64:4 Unnecessary semicolon no-extra-semi
\u2716 75:4 Unnecessary semicolon no-extra-semi
\u2716 82:4 Unnecessary semicolon no-extra-semi
\u2716 89:4 Unnecessary semicolon no-extra-semi
\u2716 100:4 Unnecessary semicolon no-extra-semi
\u2716 112:4 Unnecessary semicolon no-extra-semi
\u2716 119:4 Unnecessary semicolon no-extra-semi
\u2716 163:4 Unnecessary semicolon no-extra-semi
\u2716 171:2 Unnecessary semicolon no-extra-semi
```
commit 5d19c6f5f2b2531d7d9db61f7fd574be445226cd
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:19:16Z
fix: space-infix-ops
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js (5/0)
\u2716 70:54 Infix operators must be spaced space-infix-ops
\u2716 74:54 Infix operators must be spaced space-infix-ops
\u2716 229:52 Infix operators must be spaced space-infix-ops
\u2716 230:53 Infix operators must be spaced space-infix-ops
\u2716 231:27 Infix operators must be spaced space-infix-ops
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/helium/helium.service.js (1/0)
\u2716 108:33 Infix operators must be spaced space-infix-ops
```
commit a3f126467600e48bfcdf35fc1edae6e854d619a0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-14T16:21:52Z
fix: padded-blocks
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.test.js (2/0)
\u2716 1:43 Block must not be padded by blank lines padded-blocks
\u2716 77:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.js (1/0)
\u2716 105:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-create/notename.controller.test.js (1/0)
\u2716 40:1 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/noteName-import/notenameImport.controller.js (1/0)
\u2716 114:5 Block must not be padded by blank lines padded-blocks
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js (1/0)
\u2716 110:5 Block must not be padded by blank lines padded-blocks
```
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
rebased to resolve conflict with #2203, #2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
Merge into master if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Could you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
rebased to resolve conflict with #2244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
rebased to resolve conflict with #2133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
rebased to resolve conflict with #2203, #2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Thanks for detailed review!
Those things are about regex and mixed boolean condition (without parens), so I am sure i can keep the original intention. \U0001f62d..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Ci is now green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Could you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Yeah makes sense. Looks GOOD to me \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
rebase to resolve conflict with #2245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda CI checks has been failed sadly. Can you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Great work! Quickly looked through the most of file changes and it looks good. Zeppelin web is getting bigger, everyone will feel the necessity of this kind of lint rule.
btw I saw the below some warning msgs when I ran `npm run lint:once`,
```
$ npm run lint:once
> zeppelin-web@0.0.0 lint:once /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web
> eslint src
/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/notebook/notebook.controller.js
52:34 warning Unnecessary escape character: \/ no-useless-escape
52:44 warning Unnecessary escape character: \/ no-useless-escape
52:59 warning Unnecessary escape character: \/ no-useless-escape
52:69 warning Unnecessary escape character: \/ no-useless-escape
/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js
131:37 warning Unexpected mix of '&&' and '||' no-mixed-operators
131:54 warning Unexpected mix of '&&' and '||' no-mixed-operators
/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.js
38:40 warning Unnecessary escape character: \/ no-useless-escape
38:45 warning Unnecessary escape character: \/ no-useless-escape
\u2716 8 problems (0 errors, 8 warnings)
```
Is there any particular reason for not fixing them? If you just worried about the side effect, I think it's okay with as is :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---