You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/13 04:09:03 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4742: Refactor orch2
kimmking opened a new pull request #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742
Fixes #4701
Changes proposed in this pull request:
- modify shardingsphere-ui module references
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4742:
Refactor orch2
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742#issuecomment-598545882
Invalid commit log, please re-commit this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4742:
Refactor orch2
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4742: Refactor orch2
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742#issuecomment-598545811
## Pull Request Test Coverage Report for [Build 2088](https://coveralls.io/builds/29319935)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **63** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **59.158%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/binlog/packet/binlog/EventTypes.java](https://coveralls.io/builds/29319935/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2Fbinlog%2Fpacket%2Fbinlog%2FEventTypes.java#L27) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29319935/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/29319935/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L47) | 11 | 0% |
| [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java](https://coveralls.io/builds/29319935/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fmetadata%2Floader%2FShardingTableMetaDataLoader.java#L79) | 49 | 0% |
<!-- | **Total:** | **63** | | -->
| Totals | [](https://coveralls.io/builds/29319935) |
| :-- | --: |
| Change from base [Build 10225](https://coveralls.io/builds/29319137): | -0.08% |
| Covered Lines: | 12199 |
| Relevant Lines: | 20621 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4742:
Refactor orch2
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742#issuecomment-598544526
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=h1) Report
> Merging [#4742](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/9829d3b4e4ac09e8672b0e8914d2b010d1c64d62?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4742 +/- ##
========================================
Coverage 55.7% 55.7%
Complexity 428 428
========================================
Files 1143 1143
Lines 20793 20793
Branches 3834 3834
========================================
Hits 11583 11583
Misses 8487 8487
Partials 723 723
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=footer). Last update [9829d3b...0c686fc](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4742:
Refactor orch2
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742#issuecomment-598545811
## Pull Request Test Coverage Report for [Build 10226](https://coveralls.io/builds/29319897)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **59.241%**
---
| Totals | [](https://coveralls.io/builds/29319897) |
| :-- | --: |
| Change from base [Build 10225](https://coveralls.io/builds/29319137): | 0.0% |
| Covered Lines: | 12318 |
| Relevant Lines: | 20793 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4742: Refactor orch2
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4742: Refactor orch2
URL: https://github.com/apache/incubator-shardingsphere/pull/4742#issuecomment-598545811
## Pull Request Test Coverage Report for [Build 2089](https://coveralls.io/builds/29319936)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.08%**) to **59.318%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29319936/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29319936) |
| :-- | --: |
| Change from base [Build 10225](https://coveralls.io/builds/29319137): | 0.08% |
| Covered Lines: | 12334 |
| Relevant Lines: | 20793 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services