You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 22:15:46 UTC
[GitHub] [arrow] wjones127 opened a new issue, #15232: [Documentation] Provide guidance to contributors on getting reviews
wjones127 opened a new issue, #15232:
URL: https://github.com/apache/arrow/issues/15232
### Describe the enhancement requested
We should:
1. Provide guidance on getting reviews on PRs. We have some description in the [New Contributor's Guide](https://arrow.apache.org/docs/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request), but it might also be good to have condensed guidance on [Contributing Overview](https://arrow.apache.org/docs/developers/overview.html).
2. Create a pull request template that has an HTML comment containing links to the Contributing Overview and New Contributor's Guide pages, so they are more widely read.
### Component(s)
Developer Tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1379631860
Please see #33621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1378070933
The PR template is now active!
@westonpace well the CODEOWNERS file would be more in service of the (new) contributors so that they don't have to investigate who to ping for which changes/topics. If you want to keep an eye on everything with `watch all` this is not stopping you, you just might get an additional notification due to the review request. Procedure wise I would agree that any committer would add themselves to the relevant areas in the CODEOWNERS file. conda-forge is using this but that might be a bad comparison... but python also uses it: https://github.com/python/cpython/blob/main/.github/CODEOWNERS
> Another suggestion might be to make sure PRs are assigned to at least one reviewer,
This would only be viable if automated imo and would basically end in implementing the codeowners mechanism but with a time delay between pings vs pinging everyone assigned to these files... Also would increase the time till review quite a bit in the worst case. (as the delay would have to be something like a day minimum)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
westonpace commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1376587209
I'm in favor of more users reading the contributing guidelines / docs (they're great).
I don't know how effective assigning reviewers (or something like code owners) will be. On the one hand, I suppose I could stop looking at all notifications which is what I do today. On the other hand, I fear I would become blind to anything that wasn't modification of files I was assigned to (I assume we would just self-assign?) Have other projects had success with this?
Another suggestion might be to make sure PRs are assigned to at least one reviewer, ping reviewers when they do not respond in a reasonable amount of time and, if too much time passes, assign to a different reviewer or close. Not sure if that can be automated or would require some kind of human intervention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1374301749
Oh yeah nice idea, we should than enforce (if possible?) or at least recommend that PRs are created as drafts to avoid notification spam?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
westonpace commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1379185203
> @westonpace well the CODEOWNERS file would be more in service of the (new) contributors so that they don't have to investigate who to ping for which changes/topics.
That makes sense.
> That way people could either add themselves to the codeowners file (e.g. I would like to be in the know about all ci PRs without having to watch-all on arrow, while others could use the labels to find PRs they want to review
Being able to watch-by-component would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1378072754
But of course cpython also uses their https://github.com/bedevere-bot to label the status of PRs. @raulcd and I were discussing implementing this workflow-labeling for arrow too. That way people could either add themselves to the codeowners file (e.g. I would like to be in the know about all ci PRs without having to `watch-all` on arrow, while others could use the labels to find PRs they want to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1374203894
+:100: maybe also have a list were committers can add them selfes with components/areas they feel comfortable to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on issue #15232: [Documentation] Provide guidance to contributors on getting reviews
Posted by GitBox <gi...@apache.org>.
wjones127 commented on issue #15232:
URL: https://github.com/apache/arrow/issues/15232#issuecomment-1374233969
@assignUser what do you think about [GitHub CodeOwners](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org