[GitHub] [dubbo] chickenlj commented on a diff in pull request #11887: Support nacos disable subscribe legacy service name

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #11887:
URL: https://github.com/apache/dubbo/pull/11887#discussion_r1159352052


##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java:
##########
@@ -323,7 +325,7 @@ private Set<String> getServiceNames0(URL url) {
 
         final Set<String> serviceNames;
 
-        if (serviceName.isConcrete()) { // is the concrete service name
+        if (supportLegacyServiceName && serviceName.isConcrete()) { // is the concrete service name

Review Comment:
   Will Dubbo still subscribe to the original service name when `supportLegacyServiceName` is set to `false`? Because I didn't see the place where the original serviceName is added into serviceNames.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org