You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/27 18:16:09 UTC
[GitHub] [cloudstack-go] tetra12 opened a new pull request, #37: WIP: (#36) - support async client
tetra12 opened a new pull request, #37:
URL: https://github.com/apache/cloudstack-go/pull/37
1. Add a draft of an async request wrapper
TBD:
1. Regenerate all APIs to deploy an async client
2. Update the generator template
3. Add async test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud closed pull request #37: WIP: (#36) - support async client
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #37: WIP: (#36) - support async client
URL: https://github.com/apache/cloudstack-go/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] nvazquez commented on pull request #37: WIP: (#36) - support async client
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #37:
URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1141034123
Hi @davidjumani @Pearl1594 could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] davidjumani commented on pull request #37: WIP: (#36) - support async client
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #37:
URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1144421938
@tetra12 A better implementation would be to modify `GetAsyncJobResult` and implement channels over there rather than creating a wrapper for the request. The AsyncTimeout is while waiting for an async job, ie: if the first job is a sync job it waits for it and then times out waiting for the async job to complete. To set a timeout for any call, use the `cs.Timeout` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #37: WIP: (#36) - support async client
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #37:
URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1665872177
ping @tetra12 @davidjumani - any update on this? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #37: WIP: (#36) - support async client
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #37:
URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1271155364
Closing/re-opening PR to rekick CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: (#36) - support async client [cloudstack-go]
Posted by "tetra12 (via GitHub)" <gi...@apache.org>.
tetra12 commented on PR #37:
URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1779378444
This refactor is NOT required, since current API implements both async and timeout:
```go
func NewClient() *cloudstack.CloudStackClient {
cs := cloudstack.NewAsyncClient(apiURL, apiKey, secretKey, false)
cs.AsyncTimeout(acsTimeout)
return cs
}
```
Closing as invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: (#36) - support async client [cloudstack-go]
Posted by "tetra12 (via GitHub)" <gi...@apache.org>.
tetra12 closed pull request #37: WIP: (#36) - support async client
URL: https://github.com/apache/cloudstack-go/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org