[GitHub] [samza] sborya commented on a change in pull request #1484: SAMZA-2633: Rolling upgrades cause downtime to upgraded processors for the entire deployment window

[GitBox <gi...@apache.org>]

sborya commented on a change in pull request #1484:
URL: https://github.com/apache/samza/pull/1484#discussion_r606312946



##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java
##########
@@ -474,11 +497,55 @@ void setActiveJobModel(JobModel jobModel) {
     activeJobModel = jobModel;
   }
 
+  @VisibleForTesting
+  void setDebounceTimer(ScheduleAfterDebounceTime scheduleAfterDebounceTime) {
+    debounceTimer = scheduleAfterDebounceTime;
+  }
+
   @VisibleForTesting
   void setZkBarrierUpgradeForVersion(ZkBarrierForVersionUpgrade barrierUpgradeForVersion) {
     barrier = barrierUpgradeForVersion;
   }
 
+  /**
+   * Start the processor with the last known active job model. It is safe to start with last active job model
+   * version in all the scenarios unless the event of concurrent rebalance. We define safe as a way to ensure that no

Review comment:
       s/unless the event/unless in the event/ ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org