You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/01/30 02:16:13 UTC
[kudu-CR] WIP: Shut down tombstoned replica when replacing it
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9156
to review the following change.
Change subject: WIP: Shut down tombstoned replica when replacing it
......................................................................
WIP: Shut down tombstoned replica when replacing it
Also improve destructor state checks in TabletReplica.
This needs tests.
Change-Id: I5508b70946c9341456407c12551b19eba488d191
---
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tserver/ts_tablet_manager.cc
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/9156/1
--
To view, visit http://gerrit.cloudera.org:8080/9156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5508b70946c9341456407c12551b19eba488d191
Gerrit-Change-Number: 9156
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/9156 )
Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it
......................................................................
Abandoned
Superseded by https://gerrit.cloudera.org/c/9246/
--
To view, visit http://gerrit.cloudera.org:8080/9156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5508b70946c9341456407c12551b19eba488d191
Gerrit-Change-Number: 9156
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9156
to look at the new patch set (#2).
Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it
......................................................................
KUDU-2274. WIP: Shut down tombstoned replica when replacing it
Also improve destructor state checks in TabletReplica.
TODO: Needs a test.
Change-Id: I5508b70946c9341456407c12551b19eba488d191
---
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tserver/ts_tablet_manager.cc
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/9156/2
--
To view, visit http://gerrit.cloudera.org:8080/9156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5508b70946c9341456407c12551b19eba488d191
Gerrit-Change-Number: 9156
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9156 )
Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it
......................................................................
Patch Set 2: Code-Review+1
I think this looks good as is, but of course it would be nice to get a test to trigger the issue. I tried my test scenario posted as a WIP patch at https://gerrit.cloudera.org/#/c/9116/ against this patch (slightly modifed, just commented out old_replica->Shutdown() in TSTabletManager::RunTabletCopy()), but that didn't hit the CHECK() added in this patch.
--
To view, visit http://gerrit.cloudera.org:8080/9156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5508b70946c9341456407c12551b19eba488d191
Gerrit-Change-Number: 9156
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:48:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2274. WIP: Shut down tombstoned replica when replacing it
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9156 )
Change subject: KUDU-2274. WIP: Shut down tombstoned replica when replacing it
......................................................................
Patch Set 2:
> I think this looks good as is, but of course it would be nice to get a test to trigger the issue. I tried my test scenario posted as a WIP patch at https://gerrit.cloudera.org/#/c/9116/ against this patch (slightly modifed, just commented out old_replica->Shutdown() in TSTabletManager::RunTabletCopy()), but that didn't hit the CHECK() added in this patch.
I was able to get this to trigger some failures by running tombstoned_voting stress test so I merged this with https://gerrit.cloudera.org/c/9246/ ... see the commit message there.
--
To view, visit http://gerrit.cloudera.org:8080/9156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5508b70946c9341456407c12551b19eba488d191
Gerrit-Change-Number: 9156
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 08 Feb 2018 08:50:29 +0000
Gerrit-HasComments: No