You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Joseph Leong (JIRA)" <ji...@apache.org> on 2008/03/03 19:10:54 UTC
[jira] Created: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
When installing plugins, exception thrown when no plugins selected
------------------------------------------------------------------
Key: GERONIMO-3893
URL: https://issues.apache.org/jira/browse/GERONIMO-3893
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: console
Affects Versions: 2.1
Reporter: Joseph Leong
Assignee: Joseph Leong
Priority: Minor
If no plugins are selected (check box) to be installed, an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Leong updated GERONIMO-3893:
-----------------------------------
Affects Version/s: 2.1.1
Fix Version/s: 2.1.1
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1, 2.1.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Fix For: 2.1.1
>
> Attachments: GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3893) When installing plugins,
exception thrown when no plugins selected
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577972#action_12577972 ]
Jarek Gawor commented on GERONIMO-3893:
---------------------------------------
One minor comment. You can optimize this by exiting as soon as one selected thing is found. No need to go through the rest of the list in such case. So something like the following might work better:
for (i = 0; i < val.length; i++) {
if (val[i].checked == true) {
return true;
}
}
alert("You must choose at least one plugin to install.");
return false;
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Attachments: GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Leong updated GERONIMO-3893:
-----------------------------------
Description: In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs. (was: If no plugins are selected (check box) to be installed, an exception is thrown and a 500 error occurs.)
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Leong updated GERONIMO-3893:
-----------------------------------
Attachment: GERONIMO-3893-2.patch
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1, 2.1.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Fix For: 2.1.1
>
> Attachments: GERONIMO-3893-2.patch, GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Leong updated GERONIMO-3893:
-----------------------------------
Patch Info: [Patch Available]
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Attachments: GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3893) When installing plugins,
exception thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577959#action_12577959 ]
Joseph Leong commented on GERONIMO-3893:
----------------------------------------
Implemented Javascript to ensure one item is at least checked before rendering parameters to prevent from the 500 error.
Patch will be posted shortly!
-Joseph Leong
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joseph Leong updated GERONIMO-3893:
-----------------------------------
Attachment: GERONIMO-3893.patch
Javascript added to check whether a plugin box is checked before submitting to prevent 500 render error.
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Attachments: GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3893) When installing plugins,
exception thrown when no plugins selected
Posted by "Joseph Leong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578046#action_12578046 ]
Joseph Leong commented on GERONIMO-3893:
----------------------------------------
Silly me.. implemented.. Patch 2..
Thanks Jarek
-Joseph Leong
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1, 2.1.1
> Reporter: Joseph Leong
> Assignee: Joseph Leong
> Priority: Minor
> Fix For: 2.1.1
>
> Attachments: GERONIMO-3893-2.patch, GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3893) When installing plugins, exception
thrown when no plugins selected
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor resolved GERONIMO-3893.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Assignee: Jarek Gawor (was: Joseph Leong)
Committed the patch to trunk (revision 63660) and branches/2.1 (revision 636606). Thanks a lot!
> When installing plugins, exception thrown when no plugins selected
> ------------------------------------------------------------------
>
> Key: GERONIMO-3893
> URL: https://issues.apache.org/jira/browse/GERONIMO-3893
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1, 2.1.1
> Reporter: Joseph Leong
> Assignee: Jarek Gawor
> Priority: Minor
> Fix For: 2.1.1, 2.2
>
> Attachments: GERONIMO-3893-2.patch, GERONIMO-3893.patch
>
>
> In the administration console->plugin installer. When trying to install plugins, If no plugins are selected (check box), an exception is thrown and a 500 error occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.