[GitHub] [ozone] GlenGeng commented on a change in pull request #2148: HDDS-5090. make Decommission work under SCM HA.

[GitBox <gi...@apache.org>]

GlenGeng commented on a change in pull request #2148:
URL: https://github.com/apache/ozone/pull/2148#discussion_r612211820



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -413,38 +413,56 @@ boolean opStateDiffers(DatanodeDetails dnDetails, NodeStatus nodeStatus) {
   }
 
   /**
-   * If the operational state or expiry reported in the datanode heartbeat do
-   * not match those store in SCM, queue a command to update the state persisted
-   * on the datanode. Additionally, ensure the datanodeDetails stored in SCM
-   * match those reported in the heartbeat.
-   * This method should only be called when processing the
-   * heartbeat, and for a registered node, the information stored in SCM is the
-   * source of truth.
+   * This method should only be called when processing the heartbeat.

Review comment:
       Thanks for the hint. `testSetNodeOpStateAndCommandFired` is a good place to test the logic.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java
##########
@@ -375,4 +376,20 @@ private NodeStatus getNodeStatus(DatanodeDetails dn)
     return nodeManager.getNodeStatus(dn);
   }
 
+  /**

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org