You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/04/03 17:56:19 UTC
Re: [PR] KYLIN-4929 skip update metrics for queries that hit no realization [kylin]
codecov-commenter commented on PR #1605:
URL: https://github.com/apache/kylin/pull/1605#issuecomment-4184523525
## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1605?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 25.41%. Comparing base ([`0250081`](https://app.codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`95560e5`](https://app.codecov.io/gh/apache/kylin/commit/95560e552a81d5b4bbf15efa65275633a4d697fe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1605?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../apache/kylin/rest/metrics/QueryMetricsFacade.java](https://app.codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetricsFacade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3NGYWNhZGUuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/kylin/rest/metrics/QueryMetrics2Facade.java](https://app.codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetrics2Facade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3MyRmFjYWRlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1605 +/- ##
============================================
- Coverage 25.42% 25.41% -0.01%
+ Complexity 6765 6763 -2
============================================
Files 1508 1508
Lines 93918 93925 +7
Branches 13158 13161 +3
============================================
- Hits 23877 23873 -4
- Misses 67662 67670 +8
- Partials 2379 2382 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1605?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org