You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/07 19:26:35 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5508: Alamb/remove pwned
alamb opened a new pull request, #5508:
URL: https://github.com/apache/arrow-datafusion/pull/5508
# Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/pull/5343/files#r1123708924
# Rationale for this change
`TableReference` vs `OwnedTableReference` and having to convert back and forth between them is cumbersome to work with. This PR proposes removing the `OwnedTableReference` as `TableReference` can actually hold an owned string (via `Cow<'static>`
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jefffrey commented on pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #5508:
URL: https://github.com/apache/arrow-datafusion/pull/5508#issuecomment-1460736009
> That may help people understand how to use it better. I'll give it a try and see what it looks like
FYI I've done that implementation on #5343 already @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5508:
URL: https://github.com/apache/arrow-datafusion/pull/5508#issuecomment-1460812379
> FYI I've done that implementation on https://github.com/apache/arrow-datafusion/pull/5343 already @alamb
Awesome -- thanks @Jefffrey -- I haven't made it back to that PR yet. I'll close this PR then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jefffrey commented on pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #5508:
URL: https://github.com/apache/arrow-datafusion/pull/5508#issuecomment-1458754438
I see what you mean now, it didn't occur to me to use `'static` as the lifetime for `TableReference<'a>` 🤯
Maybe change `OwnedTableReference` to be a type alias for `TableReference<'static>`? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5508:
URL: https://github.com/apache/arrow-datafusion/pull/5508#issuecomment-1460670030
> Maybe change OwnedTableReference to be a type alias for TableReference<'static>? 🤔
That may help people understand how to use it better. I'll give it a try and see what it looks like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #5508: Consolidate `OwnedTableReference` with `TableReference`
URL: https://github.com/apache/arrow-datafusion/pull/5508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org