You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "paul8263 (via GitHub)" <gi...@apache.org> on 2024/05/13 07:54:28 UTC

[PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

paul8263 opened a new pull request, #24775:
URL: https://github.com/apache/flink/pull/24775

…ress of the Yarn NodeManager in order to support dual network environment

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

Removed setting rest.address to the actual IP address of the Yarn NodeManager in order to support dual network environment.

Given the Hadoop Yarn cluster with dual networks:
* 192.168.x.x: For data transfer. Speed: 10Gbps.
* 10.x.x.x: For management only. Speed: 1Gbps.

A client outside the Hadoop Yarn cluster is configured, with management network only(10.x.x.x) and data transfer high speed network not accessible. To reproduce, we sumbit a Flink job from this client(Batch word count for example), the job can be successfully submitted but the result cannot be retrieved, with the exception: Connection refused: {jobmanager_hostname}:{jm_port}. The root cause is the job manager rest address is bind to its actual address (192.168.x.x) rather than 0.0.0.0. Manually setting rest.bind-address does not work.

One of the changes in Flink-24474 in YarnEntrypointUtils overwrites RestOptions.BIND_ADDRESS to the node's actual address. This change should be reverted.

## Brief change log

- flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java

## Verifying this change

Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).

This change added tests and can be verified as follows:

Compiled and passed manually test.

## Does this pull request potentially affect one of the following parts:

- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no
- The S3 file system connector: no

## Documentation

- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "paul8263 (via GitHub)" <gi...@apache.org>.

paul8263 commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2456330246

   Hi @ferenc-csaky ,
   Thank you for reviewing the code. Sorry for the late response. YarnEntrypointUtilsTest has been added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.

ferenc-csaky commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2457582149

   @paul8263 pls. rebase your PR against the latest `master` and force-push again. The error that failed the CI is already addressed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "paul8263 (via GitHub)" <gi...@apache.org>.

paul8263 commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2458544855

   @ferenc-csaky ，
   Thanks. I rebased the PR and I am waiting for the CI to finish.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.

ferenc-csaky commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2400563518

   @paul8263 Logic LGTM, but pls. add a unit test to `YarnEntrypointUtilsTest` that validates we keep the preconfigured value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.

ferenc-csaky commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2459451429

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.

flinkbot commented on PR #24775:
URL: https://github.com/apache/flink/pull/24775#issuecomment-2106898008

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c8706db11eff30149877f6fffad57df225d96129",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c8706db11eff30149877f6fffad57df225d96129",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8706db11eff30149877f6fffad57df225d96129 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35332][yarn] Removed setting rest.address to the actual IP add… [flink]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.

ferenc-csaky merged PR #24775:
URL: https://github.com/apache/flink/pull/24775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org