You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Grzegorz Kochanski (JIRA)" <ji...@codehaus.org> on 2010/03/10 16:34:58 UTC
[jira] Created: (MCHANGELOG-108) read/write changelog.xml
inconsistency
read/write changelog.xml inconsistency
--------------------------------------
Key: MCHANGELOG-108
URL: http://jira.codehaus.org/browse/MCHANGELOG-108
Project: Maven 2.x Changelog Plugin
Issue Type: Bug
Affects Versions: 2.1
Reporter: Grzegorz Kochanski
Priority: Minor
ChangelogHandler.java:165
bufSet.setStartVersion(new ScmTag(attributes.getValue("startTag")));
bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
ChangeLogSet.java:180
if ( startVersion != null )
{
buffer.append( " startVersion=\"" )
.append( getStartVersion() )
.append( "\"" );
}
if ( endVersion != null )
{
buffer.append( " endVersion=\"" )
.append( getEndVersion() )
.append( "\"" );
}
Please fix field name to startVersion/endVersion.
When changelog.xml is present then settings like: type, range, dates should be taken from this file during repoprt generation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGELOG-108) read/write changelog.xml
inconsistency
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGELOG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219442#action_219442 ]
Dennis Lundberg commented on MCHANGELOG-108:
--------------------------------------------
I'm sorry, but I don't understand what it that is broken. Can you explain some more?
Please use an example: "current behavior is this, but I expected it to be that".
> read/write changelog.xml inconsistency
> --------------------------------------
>
> Key: MCHANGELOG-108
> URL: http://jira.codehaus.org/browse/MCHANGELOG-108
> Project: Maven 2.x Changelog Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Grzegorz Kochanski
> Priority: Minor
>
> ChangelogHandler.java:165
> bufSet.setStartVersion(new ScmTag(attributes.getValue("startTag")));
> bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
> ChangeLogSet.java:180
> if ( startVersion != null )
> {
> buffer.append( " startVersion=\"" )
> .append( getStartVersion() )
> .append( "\"" );
> }
> if ( endVersion != null )
> {
> buffer.append( " endVersion=\"" )
> .append( getEndVersion() )
> .append( "\"" );
> }
> Please fix field name to startVersion/endVersion.
> When changelog.xml is present then settings like: type, range, dates should be taken from this file during repoprt generation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHANGELOG-108) read/write changelog.xml inconsistency
Posted by "Samuel Van Reeth (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHANGELOG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Van Reeth updated MCHANGELOG-108:
----------------------------------------
Attachment: MCHANGELOG-108-useTagNamesFromChangeLogSetClass.patch
Fix in ChangelogHandler:
when reading the changelog.xml file, use the correct Xml tag names for attributes startVersion and endVersion
> read/write changelog.xml inconsistency
> --------------------------------------
>
> Key: MCHANGELOG-108
> URL: https://jira.codehaus.org/browse/MCHANGELOG-108
> Project: Maven 2.x Changelog Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Grzegorz Kochanski
> Priority: Minor
> Attachments: MCHANGELOG-108-useTagNamesFromChangeLogSetClass.patch
>
>
> ChangelogHandler.java:165
> bufSet.setStartVersion(new ScmTag(attributes.getValue("startTag")));
> bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
> ChangeLogSet.java:180
> if ( startVersion != null )
> {
> buffer.append( " startVersion=\"" )
> .append( getStartVersion() )
> .append( "\"" );
> }
> if ( endVersion != null )
> {
> buffer.append( " endVersion=\"" )
> .append( getEndVersion() )
> .append( "\"" );
> }
> Please fix field name to startVersion/endVersion.
> When changelog.xml is present then settings like: type, range, dates should be taken from this file during repoprt generation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHANGELOG-108) read/write changelog.xml inconsistency
Posted by "Samuel Van Reeth (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHANGELOG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=305075#comment-305075 ]
Samuel Van Reeth edited comment on MCHANGELOG-108 at 7/31/12 11:35 AM:
-----------------------------------------------------------------------
Current behaviour:
the xml is created with attributes "startVersion" and "endVersion" on element changeset (ChangeLogSet, maven-scm-api dependency), but when reading the xml, the code (ChangelogHandler.java) looks for attributes "startTag" and "endTag", finding no such attributes.
This results in a report with headers "Changes since project creation" rather than expected "Changes between...".
Fix in ChangelogHandler:
use "startVersion" and "endVersion" instead of "startTag" and "endTag" (see patch file)
was (Author: rodikal):
Current behaviour:
the xml is created with attributes "startVersion" and "endVersion" on element changeset (ChangeLogSet, maven-scm-api dependency), but when reading the xml, the code (ChangelogHandler.java) looks for attributes "startTag" and "endTag", finding no such attributes.
This results in a report with headers "Changes since project creation" rather than expected "Changes between...".
Fix in ChangelogHandler:
use "startVersion" and "endVersion" instead of "startTag" and "endTag"
> read/write changelog.xml inconsistency
> --------------------------------------
>
> Key: MCHANGELOG-108
> URL: https://jira.codehaus.org/browse/MCHANGELOG-108
> Project: Maven 2.x Changelog Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Grzegorz Kochanski
> Priority: Minor
> Attachments: MCHANGELOG-108-useTagNamesFromChangeLogSetClass.patch
>
>
> ChangelogHandler.java:165
> bufSet.setStartVersion(new ScmTag(attributes.getValue("startTag")));
> bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
> ChangeLogSet.java:180
> if ( startVersion != null )
> {
> buffer.append( " startVersion=\"" )
> .append( getStartVersion() )
> .append( "\"" );
> }
> if ( endVersion != null )
> {
> buffer.append( " endVersion=\"" )
> .append( getEndVersion() )
> .append( "\"" );
> }
> Please fix field name to startVersion/endVersion.
> When changelog.xml is present then settings like: type, range, dates should be taken from this file during repoprt generation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHANGELOG-108) read/write changelog.xml inconsistency
Posted by "Samuel Van Reeth (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHANGELOG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=305075#comment-305075 ]
Samuel Van Reeth edited comment on MCHANGELOG-108 at 7/31/12 11:34 AM:
-----------------------------------------------------------------------
Current behaviour:
the xml is created with attributes "startVersion" and "endVersion" on element changeset (ChangeLogSet, maven-scm-api dependency), but when reading the xml, the code (ChangelogHandler.java) looks for attributes "startTag" and "endTag", finding no such attributes.
This results in a report with headers "Changes since project creation" rather than expected "Changes between...".
Fix in ChangelogHandler:
use "startVersion" and "endVersion" instead of "startTag" and "endTag"
was (Author: rodikal):
Fix in ChangelogHandler:
when reading the changelog.xml file, use the correct Xml tag names for attributes startVersion and endVersion
> read/write changelog.xml inconsistency
> --------------------------------------
>
> Key: MCHANGELOG-108
> URL: https://jira.codehaus.org/browse/MCHANGELOG-108
> Project: Maven 2.x Changelog Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Grzegorz Kochanski
> Priority: Minor
> Attachments: MCHANGELOG-108-useTagNamesFromChangeLogSetClass.patch
>
>
> ChangelogHandler.java:165
> bufSet.setStartVersion(new ScmTag(attributes.getValue("startTag")));
> bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
> ChangeLogSet.java:180
> if ( startVersion != null )
> {
> buffer.append( " startVersion=\"" )
> .append( getStartVersion() )
> .append( "\"" );
> }
> if ( endVersion != null )
> {
> buffer.append( " endVersion=\"" )
> .append( getEndVersion() )
> .append( "\"" );
> }
> Please fix field name to startVersion/endVersion.
> When changelog.xml is present then settings like: type, range, dates should be taken from this file during repoprt generation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira