You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2015/05/26 11:23:17 UTC
[jira] [Comment Edited] (LUCENE-6500) ParallelCompositeReader does
not always call closed listeners
[ https://issues.apache.org/jira/browse/LUCENE-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558911#comment-14558911 ]
Uwe Schindler edited comment on LUCENE-6500 at 5/26/15 9:23 AM:
----------------------------------------------------------------
Here is the problem, why the patch is problematic:
The current logic is fine, but fails - as Adrien says - when you have a ParallelMultiReader on a MultiReader of another CompositeReaders.
His fix works fine in the test because the MultiReader has closeSubReaders=true - so it does no refcounting. If you have closeSubReader=false on the parallel on and also on the child MultiReader. in that case it will fail with too many decRefs (haven't tried).
I am not sure how the best fix looks like. It this issue urgent? I have to think a night about it :-) I would prefer to have a better solution alltgether, this refcounting is horrible...
was (Author: thetaphi):
Here is the problem, why the patch is problematic:
The current logic is fine, but fails - as Adrien says - when you have a ParallelMultiReader on a MultiReader of another CompositeReaders.
His fix works fine, if you have closeSubReader=false on the parallel on and also on the child MultiReaders. in that case it will fail with too many decRefs.
I am not sure how the best fix looks like. It this issue urgent? I have to think a night about it :-) I would prefer to have a better solution alltgether, this refcounting is horrible...
> ParallelCompositeReader does not always call closed listeners
> -------------------------------------------------------------
>
> Key: LUCENE-6500
> URL: https://issues.apache.org/jira/browse/LUCENE-6500
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-6500.patch
>
>
> CompositeParallelReader misses to call closed listeners when the reader which is provided at construction time does not wrap leaf readers directly, such as a multi reader over directory readers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org