You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "jerqi (via GitHub)" <gi...@apache.org> on 2024/12/27 11:36:10 UTC
[PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
jerqi opened a new pull request, #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310
### What changes were proposed in this pull request?
Add left jars with Apache license
### Why are the changes needed?
Fix #2307
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [uniffle]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #2310:
URL: https://github.com/apache/uniffle/pull/2310#discussion_r2043821238
##########
LICENSE-binary:
##########
@@ -303,3 +344,8 @@ org.apache.hbase.thirdparty:hbase-shaded-jersey
The ISC License
---------------
rimraf
+
Review Comment:
When something is available under multiple licenses, you should select the license that is compatable with the ASF license/policy. See https://www.apache.org/legal/resolved.html#mutually-exclusive
##########
LICENSE-binary:
##########
@@ -303,3 +344,8 @@ org.apache.hbase.thirdparty:hbase-shaded-jersey
The ISC License
---------------
rimraf
+
Review Comment:
When something is available under multiple licenses, you should select the license that is compatable with the ASF license/policy. See https://www.apache.org/legal/resolved.html#mutually-exclusive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563652273
## Test Results
2 966 files ±0 2 966 suites ±0 6h 26m 24s ⏱️ - 1m 2s
1 097 tests ±0 1 095 ✅ ±0 2 💤 ±0 0 ❌ ±0
13 750 runs ±0 13 720 ✅ ±0 30 💤 ±0 0 ❌ ±0
Results for commit 1b32e249. ± Comparison against base commit 1c56e74c.
[test-results]:data:application/gzip;base64,H4sIAFicbmcC/03MQQ6DIBCF4asY1l0MMyLSyzQKmJCqNAgr07sXtaLL9zH8KxvcaBf2rFA1zaNiS3Lxvk0KXXR+3oR4W2fK73G74KDkOV9L0vowcdnbfbZ/BYbOjRmggA3Bh7+ENO9VkuKcpUoSLzuqVOBW3fc9qv00uZgH4z2hxVqhAbKmBm0bDiBUq4xBwJ5rqzgZwb4/ep165BQBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563658820
> > I don't think org.javassist:javassist is Apache licensed.
> > https://mvnrepository.com/artifact/javassist/javassist says it is LGPL and MPL licensed. LGPL is a problem but MPL is Category B and is ok. So we can use the jar.
>
> It actually looks like org.javassist:javassist is licensed under 3 licenses (the 2 above and Apache license too which is better).
>
> https://repo1.maven.org/maven2/org/javassist/javassist/3.30.2-GA/javassist-3.30.2-GA.pom
>
> Could we update the LICENSE-binary to name the 3 licenses instead of grouping it under Apache license alone?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2564958800
@pjfanning Do you have other suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563621798
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2310?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 52.01%. Comparing base [(`44bfd0d`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/44bfd0da8a501f8d1d95cf4ef28745304553de50?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9807049`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/980704986bc9ea7be787d8359431dedd87382b4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2310 +/- ##
============================================
- Coverage 52.27% 52.01% -0.26%
+ Complexity 3569 2937 -632
============================================
Files 543 465 -78
Lines 29797 22167 -7630
Branches 2779 2041 -738
============================================
- Hits 15575 11530 -4045
+ Misses 13227 9920 -3307
+ Partials 995 717 -278
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2310?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [uniffle]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #2310:
URL: https://github.com/apache/uniffle/pull/2310#discussion_r2043821706
##########
LICENSE-binary:
##########
@@ -303,3 +344,8 @@ org.apache.hbase.thirdparty:hbase-shaded-jersey
The ISC License
---------------
rimraf
+
+The Apache Software License, Version 2.0, LGPL License or MPL License
Review Comment:
When something is available under multiple licenses, you should select the license that is compatable with the ASF license/policy. See https://www.apache.org/legal/resolved.html#mutually-exclusive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563662015
> LGPL
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563648818
> I don't think org.javassist:javassist is Apache licensed.
>
> https://mvnrepository.com/artifact/javassist/javassist says it is LGPL and MPL licensed. LGPL is a problem but MPL is Category B and is ok. So we can use the jar.
It actually looks like org.javassist:javassist is licensed under 3 licenses (the 2 above and Apache license too which is better).
https://repo1.maven.org/maven2/org/javassist/javassist/3.30.2-GA/javassist-3.30.2-GA.pom
Could we update the LICENSE-binary to name the 3 licenses instead of grouping it under Apache license alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2563645448
I don't think org.javassist:javassist is Apache licensed.
https://mvnrepository.com/artifact/javassist/javassist says it is LGPL and MPL licensed. LGPL is a problem but MPL is Category B and is ok. So we can use the jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2566284351
> @pjfanning Do you have any other suggestion?
seems ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2307] license: Add left jars with Apache license [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2310:
URL: https://github.com/apache/incubator-uniffle/pull/2310#issuecomment-2566075110
@pjfanning Do you have any other suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org