[GitHub] [pulsar] eolivelli commented on a change in pull request #11441: [PIP-88] Replicate schemas across clusters

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11441:
URL: https://github.com/apache/pulsar/pull/11441#discussion_r679665983



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -418,14 +419,24 @@ private void ensureSchemaIsLoaded() {
         }
     }
 
-    private SchemaInfo getSchemaInfo() {
+    public SchemaInfo getSchemaInfo() {
+        if (schemaInfo != null) {

Review comment:
       this is quite confusing, we should use what the internal Schema is reporting

##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -64,6 +64,7 @@
     private ByteBuf payload;
 
     private Schema<T> schema;
+    private SchemaInfo schemaInfo;

Review comment:
       I second @315157973 concern.
   We already have "getReaderSchema", why cannot we use that ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org