You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Enrico Olivelli <eo...@gmail.com> on 2022/09/21 07:17:50 UTC
BookieId is broken on 2.10+
Hello folks,
I have found that since Pulsar 2.10 you cannot set a custom BookieId anymore.
The fix is easy
https://github.com/apache/pulsar/pull/17762
I am pretty sure it worked on Pulsar 2.8 (I sent out a patch for
supporting the bookieId on the Helm Chart).
I think that we should cherry-pick the patch to 2.11.0 and to 2.10.2,
otherwise users upgrading from 2.8 to 2.10 or 2.11 that use BookieId
won't be able to upgrade
Thoughts ?
Enrico
Re: BookieId is broken on 2.10+
Posted by mattison chao <ma...@apache.org>.
Nice!
Best,
Mattison
On Thu, 22 Sept 2022 at 11:21, Michael Marshall <mm...@apache.org>
wrote:
> Great catch, Enrico. I saw the returned `null` in
> `BookieServiceInfoSerde#deserialize`, but I didn't know its impact.
>
> Thanks,
> Michael
>
> On Wed, Sep 21, 2022 at 8:30 AM Haiting Jiang <ji...@gmail.com>
> wrote:
> >
> > Sure, I have added the release label in this PR.
> >
> > BTW, the 2.10.2 release is almost ready for RC1 except that there is
> > an owasp ci failure on branch-2.10. Please help take a look.
> > https://github.com/apache/pulsar/pull/17765
> >
> > Thanks,
> > Haiting
> >
> > On Wed, Sep 21, 2022 at 3:18 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
> > >
> > > Hello folks,
> > > I have found that since Pulsar 2.10 you cannot set a custom BookieId
> anymore.
> > >
> > > The fix is easy
> > > https://github.com/apache/pulsar/pull/17762
> > >
> > > I am pretty sure it worked on Pulsar 2.8 (I sent out a patch for
> > > supporting the bookieId on the Helm Chart).
> > >
> > > I think that we should cherry-pick the patch to 2.11.0 and to 2.10.2,
> > > otherwise users upgrading from 2.8 to 2.10 or 2.11 that use BookieId
> > > won't be able to upgrade
> > >
> > >
> > > Thoughts ?
> > >
> > > Enrico
>
Re: BookieId is broken on 2.10+
Posted by Michael Marshall <mm...@apache.org>.
Great catch, Enrico. I saw the returned `null` in
`BookieServiceInfoSerde#deserialize`, but I didn't know its impact.
Thanks,
Michael
On Wed, Sep 21, 2022 at 8:30 AM Haiting Jiang <ji...@gmail.com> wrote:
>
> Sure, I have added the release label in this PR.
>
> BTW, the 2.10.2 release is almost ready for RC1 except that there is
> an owasp ci failure on branch-2.10. Please help take a look.
> https://github.com/apache/pulsar/pull/17765
>
> Thanks,
> Haiting
>
> On Wed, Sep 21, 2022 at 3:18 PM Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > Hello folks,
> > I have found that since Pulsar 2.10 you cannot set a custom BookieId anymore.
> >
> > The fix is easy
> > https://github.com/apache/pulsar/pull/17762
> >
> > I am pretty sure it worked on Pulsar 2.8 (I sent out a patch for
> > supporting the bookieId on the Helm Chart).
> >
> > I think that we should cherry-pick the patch to 2.11.0 and to 2.10.2,
> > otherwise users upgrading from 2.8 to 2.10 or 2.11 that use BookieId
> > won't be able to upgrade
> >
> >
> > Thoughts ?
> >
> > Enrico
Re: BookieId is broken on 2.10+
Posted by Haiting Jiang <ji...@gmail.com>.
Sure, I have added the release label in this PR.
BTW, the 2.10.2 release is almost ready for RC1 except that there is
an owasp ci failure on branch-2.10. Please help take a look.
https://github.com/apache/pulsar/pull/17765
Thanks,
Haiting
On Wed, Sep 21, 2022 at 3:18 PM Enrico Olivelli <eo...@gmail.com> wrote:
>
> Hello folks,
> I have found that since Pulsar 2.10 you cannot set a custom BookieId anymore.
>
> The fix is easy
> https://github.com/apache/pulsar/pull/17762
>
> I am pretty sure it worked on Pulsar 2.8 (I sent out a patch for
> supporting the bookieId on the Helm Chart).
>
> I think that we should cherry-pick the patch to 2.11.0 and to 2.10.2,
> otherwise users upgrading from 2.8 to 2.10 or 2.11 that use BookieId
> won't be able to upgrade
>
>
> Thoughts ?
>
> Enrico