You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "phillipleblanc (via GitHub)" <gi...@apache.org> on 2025/01/27 13:46:33 UTC
[PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
phillipleblanc opened a new pull request, #917:
URL: https://github.com/apache/iceberg-rust/pull/917
Implements basic support for connecting to the AWS Glue Iceberg REST catalog by supporting the parameters `rest.sigv4-enabled`, `rest.signing-name` and `rest.signing-region`. See the corresponding parameters in the PyIceberg docs: https://py.iceberg.apache.org/configuration/#rest-catalog
I've added a new feature to the `iceberg-catalog-rest` called `sigv4` which when enabled, will recognize the above configuration parameters. I've left this disabled by default.
I added the crate `request_middleware` to allow running middleware on requests, and if the `rest.sigv4-enabled` configuration is enabled, the middleware to sign the request and add the correct `Authorization` header is enabled.
I've tested this implementation in my project, and it works great for connecting to the AWS Glue REST catalog, i.e. `https://glue.<region>.amazonaws.com/iceberg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #917:
URL: https://github.com/apache/iceberg-rust/pull/917#issuecomment-4001167670
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
Posted by "phillipleblanc (via GitHub)" <gi...@apache.org>.
phillipleblanc commented on PR #917:
URL: https://github.com/apache/iceberg-rust/pull/917#issuecomment-3290101907
Closing because https://github.com/apache/iceberg-rust/pull/1241 should be the preferred approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
Posted by "phillipleblanc (via GitHub)" <gi...@apache.org>.
phillipleblanc commented on PR #917:
URL: https://github.com/apache/iceberg-rust/pull/917#issuecomment-2808148922
> Hi @phillipleblanc
>
> I found this PR while digging into how to query AWS' REST catalog implementation for S3 Tables. What would it take to get this PR merged? How can I assist?
I think we might need to rework this to not depend on the aws crates for the signing part - that seems to have some conflicts I wasn't able to resolve with the MSRV check. Looking at how the object_store crate does it would be a good start: https://github.com/apache/arrow-rs-object-store/blob/main/src/aws/credential.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
Posted by "simonvandel (via GitHub)" <gi...@apache.org>.
simonvandel commented on PR #917:
URL: https://github.com/apache/iceberg-rust/pull/917#issuecomment-2805013998
Hi @phillipleblanc
I found this PR while digging into how to query AWS' REST catalog implementation for S3 Tables.
What would it take to get this PR merged? How can I assist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #917: Implement basic support for `rest.sigv4_enabled` for the Iceberg REST catalog
URL: https://github.com/apache/iceberg-rust/pull/917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org