Re: [PR] RATIS-1925. Support Zero-Copy in GrpcClientProtocolService [ratis]

["duongkame (via GitHub)" <gi...@apache.org>]

duongkame commented on PR #990:
URL: https://github.com/apache/ratis/pull/990#issuecomment-1876500256

   @szetszwo My basic assumption is that hat when applied and follower indices reach a particular point, x, we can safely clean up any zero-copy for write/appendEntries up to x (0-x).  I did that in the Ozone PoC and that works fine. But I'm not sure if it's correct universally for any use-cases.
   
   I think your suggestion is a better approach. Only concern is that it may lead to a more complex change as we need to pass the `ReferenceCountedObject` from GRPC to raft internal. E.g. for ClientServiceProtocol (appendEntries) we may need to change the `RaftServerAsynchronousProtocol.appendEntriesAsync` because now it only accepts a protobuf object. 
   Anyway, I think it's viable. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org