You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amruth Sampath <am...@gmail.com> on 2015/11/03 13:28:20 UTC
Review Request 39897: LENS-860 : Updating committer documentation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Repository: lens
Description
-------
Have updated the documentation
Diffs
-----
src/site/apt/developer/commit.apt f908925
Diff: https://reviews.apache.org/r/39897/diff/
Testing
-------
No code changes to test.
Thanks,
Amruth Sampath
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review104903
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 49)
<https://reviews.apache.org/r/39897/#comment163226>
Change PPMC to PMC in all places.
- Rajat Khandelwal
On Nov. 3, 2015, 5:58 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 5:58 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have updated the documentation
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> -------
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 3, 2015, 1:23 p.m., Raju Bairishetti wrote:
> > src/site/apt/developer/commit.apt, line 38
> > <https://reviews.apache.org/r/39897/diff/1/?file=1114507#file1114507line38>
> >
> > IMHO, If invited as PMC then role should be only PMC. We can specify roles as PMC & Committer only if invited for **both** PMC & Committer.
PMC would be already a committer or a new committer, so should be fine.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review104905
-----------------------------------------------------------
On Nov. 3, 2015, 12:28 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 12:28 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have updated the documentation
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> -------
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review104905
-----------------------------------------------------------
src/site/apt/developer/commit.apt (line 38)
<https://reviews.apache.org/r/39897/#comment163230>
IMHO, If invited as PMC then role should be only PMC. We can specify roles as PMC & Committer only if invited for **both** PMC & Committer.
- Raju Bairishetti
On Nov. 3, 2015, 12:28 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 12:28 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have updated the documentation
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> -------
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/#review105360
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Nov. 4, 2015, 8:22 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 8:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have updated the documentation
>
>
> Diffs
> -----
>
> pom.xml 5e8f046
> src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> -------
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Amruth Sampath <am...@flipkart.com>.
HI all, Is this good to go?
On Wed, Nov 4, 2015 at 1:52 PM, Amruth Sampath <am...@gmail.com>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 8:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Changes
> -------
>
> Corrected PPMC to PMC at all places in pom.xml
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have updated the documentation
>
>
> Diffs (updated)
> -----
>
> pom.xml 5e8f046
> src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> -------
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>
--
Amruth S
(09486075517)
Re: Review Request 39897: LENS-860 : Updating committer documentation
Posted by Amruth Sampath <am...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 8:22 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Corrected PPMC to PMC at all places in pom.xml
Repository: lens
Description
-------
Have updated the documentation
Diffs (updated)
-----
pom.xml 5e8f046
src/site/apt/developer/commit.apt f908925
Diff: https://reviews.apache.org/r/39897/diff/
Testing
-------
No code changes to test.
Thanks,
Amruth Sampath