You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Russole (via GitHub)" <gi...@apache.org> on 2026/06/11 14:35:53 UTC
[PR] MINOR: Share common implementation for downstream offset translation boundary in MirrorMaker offset syncs [kafka]
Russole opened a new pull request, #22543:
URL: https://github.com/apache/kafka/pull/22543
This is a small refactor to resolve the TODO in [`OffsetSyncWriter`](https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncWriter.java#L172-L174) by centralizing the downstream offset boundary calculation used by MirrorMaker offset sync translation.
The existing behavior is unchanged. `OffsetSyncStore` and `OffsetSyncWriter` now share the same implementation in `OffsetSync` instead of duplicating the `downstreamOffset + 1` logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Share common implementation for downstream offset translation boundary in MirrorMaker offset syncs [kafka]
Posted by "Russole (via GitHub)" <gi...@apache.org>.
Russole commented on PR #22543:
URL: https://github.com/apache/kafka/pull/22543#issuecomment-4826678724
Thanks @mimaison for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Share common implementation for downstream offset translation boundary in MirrorMaker offset syncs [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22543:
URL: https://github.com/apache/kafka/pull/22543#issuecomment-4748530350
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Share common implementation for downstream offset translation boundary in MirrorMaker offset syncs [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #22543:
URL: https://github.com/apache/kafka/pull/22543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org