[GitHub] [incubator-doris] imay commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result 
URL: https://github.com/apache/incubator-doris/pull/1686#discussion_r316523679
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java
 ##########
 @@ -118,6 +120,13 @@
     // only for persistence param
     private boolean isJobTypeRead = false;
 
+    // number of rows processed on BE, this number will be updated periodically by query report.
+    // A load job may has several load tasks, so the map key is load task's plan load id.
+    protected Map<TUniqueId, AtomicLong> numLoadedRows = Maps.newConcurrentMap();
 
 Review comment:
   I think it's better to make RuntimeStatics, not only numLoadedRows.
   And it name should be xxxMap.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org