[GitHub] [incubator-pinot] ChethanUK commented on a change in pull request #6839: Update helm chart - Include securityContext, gracePeriod and remove duplicates in helm

[GitBox <gi...@apache.org>]

ChethanUK commented on a change in pull request #6839:
URL: https://github.com/apache/incubator-pinot/pull/6839#discussion_r639930169



##########
File path: kubernetes/helm/pinot/templates/broker/service.yaml
##########
@@ -21,18 +21,18 @@ apiVersion: v1
 kind: Service
 metadata:
   name: {{ include "pinot.broker.fullname" . }}
+  annotations:
+    type: "service"
+  {{- if .Values.broker.service.gcpInternalLB }}
+    cloud.google.com/load-balancer-type: Internal

Review comment:
       Ya, I was thinking more in sense of load balancer point of view :(
   Sent a PR: https://github.com/apache/incubator-pinot/pull/6985




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org