You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "iskanderknani2005-oss (via GitHub)" <gi...@apache.org> on 2026/04/26 13:39:54 UTC
[PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
iskanderknani2005-oss opened a new pull request, #39662:
URL: https://github.com/apache/superset/pull/39662
Body:
Fixes #39631
The wrapper div in TablePreview used flex: 1 1 auto but had no
overflow-x rule. Wide tables were silently clipped with no horizontal
scroll bar. Added overflow-x: auto — one line, zero logic risk.
base repository: apache/superset base: master
head repository: iskanderknani2005-oss/superset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39662:
URL: https://github.com/apache/superset/pull/39662#issuecomment-4322153175
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39662:
URL: https://github.com/apache/superset/pull/39662#issuecomment-4322163528
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 8d4d5d814b1048b6f9fe0753490e0b1e63fac4ce |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69ee15aae118500008031a7c |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39662--superset-docs-preview.netlify.app](https://deploy-preview-39662--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-39662--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #39662:
URL: https://github.com/apache/superset/pull/39662#issuecomment-4322265540
Thanks for opening the PR but this doesn't fix the linked issue tho. The issue is still present after applying the change on my local machine
https://github.com/user-attachments/assets/dc6af2be-cb86-48bd-8367-f337daf5f9b1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #39662:
URL: https://github.com/apache/superset/pull/39662#issuecomment-4443569465
@iskanderknani2005-oss is this PR still needed? I see it's trying to fix an issue that has already been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #39662:
URL: https://github.com/apache/superset/pull/39662#issuecomment-4773862033
Looks like #39631 already got fixed in #39799, and @hainenber couldn't repro the fix from this change locally. I think we can close this one out — but @iskanderknani2005-oss let me know if you're still seeing the scrollbar missing on master and we'll happily reopen and take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #39662: fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll
URL: https://github.com/apache/superset/pull/39662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org