You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/10 01:54:05 UTC
[jira] [Commented] (STORM-1104) Nimbus HA fails to find newly
downloaded code files
[ https://issues.apache.org/jira/browse/STORM-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951417#comment-14951417 ]
ASF GitHub Bot commented on STORM-1104:
---------------------------------------
GitHub user schonfeld opened a pull request:
https://github.com/apache/storm/pull/794
[STORM-1104] Nimbus HA fails to find newly downloaded code files
Nimbus HA using Local File System code distribution is broken. We seem to be "caching" the return value of `(code-ids (:conf nimbus))` in the sync-code method, by overriding the `code-ids` var from a method ([nimbus.clj#854](../blob/master/storm-core/src/clj/backtype/storm/daemon/nimbus.clj#L854) `defn code-ids`), to a local var ([nimbus.clj#1669](../blob/master/storm-core/src/clj/backtype/storm/daemon/nimbus.clj#L1669) `code-ids (set (code-ids (:conf nimbus)))`).
The problem is, that after downloading code for missing topologies, sync-code doesn't realize it has gotten the new missing topology files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schonfeld/storm nimbus-ha-fails-to-find-code-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #794
----
commit ba1250993d10ffc523c9f5464371fbeb406d216f
Author: Michael Schonfeld <mi...@schonfeld.org>
Date: 2015-10-09T23:48:41Z
dont override code-ids method
----
> Nimbus HA fails to find newly downloaded code files
> ---------------------------------------------------
>
> Key: STORM-1104
> URL: https://issues.apache.org/jira/browse/STORM-1104
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.11.0
> Reporter: Michael Schonfeld
> Assignee: Michael Schonfeld
>
> Nimbus HA using Local File System code distribution is broken. We seem to be "caching" the return value of `(code-ids (:conf nimbus))` in the sync-code method, by overriding the `code-ids` var from a method (#854 `defn code-ids`), to a local var (#1669 `code-ids (set (code-ids (:conf nimbus)))`).
> The problem is, that after downloading code for missing topologies, sync-code doesn't realize it has gotten the new missing topology files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)