You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/01/27 22:25:29 UTC
[GitHub] [druid] techdocsmith opened a new pull request, #13719: Adds techdocsmith and vtlim as code owners for documentation related …
techdocsmith opened a new pull request, #13719:
URL: https://github.com/apache/druid/pull/13719
This PR uses the CODEOWNERS file as a workaround for notifications since GitHub doesn't allow watching a directory within a repo. @techdocsmith and @vtlim are Druid committers focused exclusively on the documentation, so it makes sense for them to be notified on changes. It'll also help catch PRs that need the `Area - Documentation` label applied and doc reviews.
This does not change the repo settings to require a review from code owners, so there's no change to any review requirements for PRs. Any committer will still be able to approve a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13719:
URL: https://github.com/apache/druid/pull/13719#discussion_r1091023647
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,3 @@
+# Adds techdocsmith and vtlim as code owners for documentation related directories.
+/docs/** @techdocsmith @vtlim
+/examples/quickstart/jupyter-notebooks/** @techdocsmith @vtlim
Review Comment:
Nit: missing newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a diff in pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #13719:
URL: https://github.com/apache/druid/pull/13719#discussion_r1093898510
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,3 @@
+# Adds techdocsmith and vtlim as code owners for documentation related directories.
+/docs/** @techdocsmith @vtlim
+/examples/quickstart/jupyter-notebooks/** @techdocsmith @vtlim
Review Comment:
```suggestion
/examples/quickstart/jupyter-notebooks/** @techdocsmith @vtlim
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on PR #13719:
URL: https://github.com/apache/druid/pull/13719#issuecomment-1412993976
Converted to draft while we look at another solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on PR #13719:
URL: https://github.com/apache/druid/pull/13719#issuecomment-1442453146
Superseded by #13791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith closed pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith closed pull request #13719: Adds techdocsmith and vtlim as code owners for documentation related …
URL: https://github.com/apache/druid/pull/13719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org