You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dan Sully (JIRA)" <ji...@apache.org> on 2008/09/04 19:23:44 UTC
[jira] Created: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Ruby generator should use ::Thrift::Foo namespace form
------------------------------------------------------
Key: THRIFT-132
URL: https://issues.apache.org/jira/browse/THRIFT-132
Project: Thrift
Issue Type: Bug
Components: Compiler (Ruby)
Environment: Any
Reporter: Dan Sully
The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
include ::Thrift::Client
otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667821#action_12667821 ]
Bryan Duxbury commented on THRIFT-132:
--------------------------------------
Dan, can you try this patch out and let me know if it solves the problem?
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-132:
------------------------------------
Assignee: Bryan Duxbury
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670066#action_12670066 ]
Bryan Duxbury commented on THRIFT-132:
--------------------------------------
Great. I just committed this.
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Fix For: 0.1
>
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-132:
---------------------------------
Fix Version/s: 0.1
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Fix For: 0.1
>
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Dan Sully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Sully resolved THRIFT-132.
------------------------------
Resolution: Fixed
Yep - that works for me.
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Fix For: 0.1
>
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-132:
---------------------------------
Attachment: thrift-132.patch
I think this will do it.
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-132) Ruby generator should use
::Thrift::Foo namespace form
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-132:
---------------------------------
Patch Info: [Patch Available]
> Ruby generator should use ::Thrift::Foo namespace form
> ------------------------------------------------------
>
> Key: THRIFT-132
> URL: https://issues.apache.org/jira/browse/THRIFT-132
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Environment: Any
> Reporter: Dan Sully
> Attachments: thrift-132.patch
>
>
> The Thrift compiler for Ruby should generate code such that it uses the top level namespace:
> include ::Thrift::Client
> otherwise, if there is an existing namespace with 'Thrift' in the hierarchy, Ruby will fail to find that class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.