[GitHub] [accumulo] ctubbsii commented on issue #1353: Avoid calling auto-close on Accumulo client

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1353: Avoid calling auto-close on Accumulo client
URL: https://github.com/apache/accumulo/pull/1353#issuecomment-529054877
 
 
   One difference with this code and what was there before this and #1348 is that Exceptions thrown by the `bw.close()` method no longer get wrapped with an `AccumuloException`. In particular, this `close` method can return `MutationsRejectedException`, which is already an instance of `AccumuloException`. If any code relied on those being wrapped, such code could fail or behave incorrectly, when it tries to unwrap the `AccumuloException` now thrown here. The same is true for RTEs, including `InterruptedException` which is wrapped by a RTE in `TabletServerBatchWriter.close()` called by `BatchWriterImpl.close()`.
   
   If no calling code tries to unwrap these exceptions, and merely propagates them to be logged or to kill the JVM, it probably doesn't matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services