You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "RobertIndie (via GitHub)" <gi...@apache.org> on 2023/03/24 09:49:13 UTC

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #19915: [fix][client] Fix client erroneous code comments

RobertIndie commented on code in PR #19915:
URL: https://github.com/apache/pulsar/pull/19915#discussion_r1147336787


##########
pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java:
##########
@@ -158,7 +158,7 @@ public int getIoThreads() {
     }
 
     /**
-     * Set the number of threads to be used for handling connections to brokers <i>(default: 1 thread)</i>.
+     * Set the number of threads to be used for handling connections to brokers <i>(default is Runtime.getRuntime().availableProcessors())</i>.

Review Comment:
   The module `pulsar-client-1x` is deprecated. You can make your changes here: https://github.com/apache/pulsar/blob/c172a775fa0fc5762a9703669ed8ebcd2efbe042/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java#L245-L263



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org