[GitHub] [httpcomponents-client] gknapowski commented on a change in pull request #143: Changed route tracking of proxy to not default to false

[GitBox <gi...@apache.org>]

gknapowski commented on a change in pull request #143: Changed route tracking of proxy to not default to false
URL: https://github.com/apache/httpcomponents-client/pull/143#discussion_r265270261
 
 

 ##########
 File path: httpclient/src/main/java/org/apache/http/impl/execchain/MainClientExec.java
 ##########
 @@ -404,7 +404,7 @@ void establishRoute(
                         timeout > 0 ? timeout : 0,
                         context);
                 final HttpHost proxy  = route.getProxyHost();
-                tracker.connectProxy(proxy, false);
+                tracker.connectProxy(proxy, route.isSecure());
 
 Review comment:
   I agree.  I tested with use cases.  I also tested with a secure connection to the Proxy with Tunneling.  Both work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org