You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/06/30 10:37:48 UTC
Review Request 60565: Force to use JDK 8 for Ambari Server maven build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
Bugs: AMBARI-21380
https://issues.apache.org/jira/browse/AMBARI-21380
Repository: ambari
Description
-------
add source/target versions for compiler plugin and uses 1.8 there
Diffs
-----
ambari-server/pom.xml 4b75d9b
Diff: https://reviews.apache.org/r/60565/diff/1/
Testing
-------
done, failing with jdk 7
Thanks,
Oliver Szabo
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/#review179377
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On June 30, 2017, 10:37 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60565/
> -----------------------------------------------------------
>
> (Updated June 30, 2017, 10:37 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21380
> https://issues.apache.org/jira/browse/AMBARI-21380
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add source/target versions for compiler plugin and uses 1.8 there
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4b75d9b
>
>
> Diff: https://reviews.apache.org/r/60565/diff/1/
>
>
> Testing
> -------
>
> done, failing with jdk 7
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/#review179566
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On July 4, 2017, 11:59 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60565/
> -----------------------------------------------------------
>
> (Updated July 4, 2017, 11:59 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21380
> https://issues.apache.org/jira/browse/AMBARI-21380
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add source/target versions for compiler plugin and uses 1.8 there
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4b75d9b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 1f906ad
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java fd3f4e4
>
>
> Diff: https://reviews.apache.org/r/60565/diff/4/
>
>
> Testing
> -------
>
> done, failing with jdk 7
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/
-----------------------------------------------------------
(Updated July 4, 2017, 11:59 a.m.)
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
Changes
-------
remove -XX:maxPermSize param
Bugs: AMBARI-21380
https://issues.apache.org/jira/browse/AMBARI-21380
Repository: ambari
Description
-------
add source/target versions for compiler plugin and uses 1.8 there
Diffs (updated)
-----
ambari-server/pom.xml 4b75d9b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 1f906ad
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java fd3f4e4
Diff: https://reviews.apache.org/r/60565/diff/4/
Changes: https://reviews.apache.org/r/60565/diff/3-4/
Testing
-------
done, failing with jdk 7
Thanks,
Oliver Szabo
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/#review179516
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On July 3, 2017, 6:43 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60565/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 6:43 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21380
> https://issues.apache.org/jira/browse/AMBARI-21380
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add source/target versions for compiler plugin and uses 1.8 there
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4b75d9b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 1f906ad
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java fd3f4e4
>
>
> Diff: https://reviews.apache.org/r/60565/diff/3/
>
>
> Testing
> -------
>
> done, failing with jdk 7
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/
-----------------------------------------------------------
(Updated July 3, 2017, 4:43 p.m.)
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
Changes
-------
fix weird (ordering) powermock issue with jdk 8 as well
Bugs: AMBARI-21380
https://issues.apache.org/jira/browse/AMBARI-21380
Repository: ambari
Description
-------
add source/target versions for compiler plugin and uses 1.8 there
Diffs (updated)
-----
ambari-server/pom.xml 4b75d9b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 1f906ad
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java fd3f4e4
Diff: https://reviews.apache.org/r/60565/diff/3/
Changes: https://reviews.apache.org/r/60565/diff/2-3/
Testing
-------
done, failing with jdk 7
Thanks,
Oliver Szabo
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/
-----------------------------------------------------------
(Updated July 3, 2017, 2:37 p.m.)
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
Changes
-------
fix ambiguous test-compile error
Bugs: AMBARI-21380
https://issues.apache.org/jira/browse/AMBARI-21380
Repository: ambari
Description
-------
add source/target versions for compiler plugin and uses 1.8 there
Diffs (updated)
-----
ambari-server/pom.xml 4b75d9b
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java fd3f4e4
Diff: https://reviews.apache.org/r/60565/diff/2/
Changes: https://reviews.apache.org/r/60565/diff/1-2/
Testing
-------
done, failing with jdk 7
Thanks,
Oliver Szabo
Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven
build
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60565/#review179371
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On June 30, 2017, 10:37 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60565/
> -----------------------------------------------------------
>
> (Updated June 30, 2017, 10:37 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21380
> https://issues.apache.org/jira/browse/AMBARI-21380
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add source/target versions for compiler plugin and uses 1.8 there
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4b75d9b
>
>
> Diff: https://reviews.apache.org/r/60565/diff/1/
>
>
> Testing
> -------
>
> done, failing with jdk 7
>
>
> Thanks,
>
> Oliver Szabo
>
>