You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mushketyk <gi...@git.apache.org> on 2016/08/28 12:05:50 UTC
[GitHub] flink pull request #2431: [FLINK-4521] Fix "Submit new Job" panel in develop...
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2431
[FLINK-4521] Fix "Submit new Job" panel in development mode
Submit panel was completely empty in the development mode. This happened because client-side code sent AJAX requests to a development HTTP server (`localhost:3000`) and not to the the JobServer (`localhost:8081`) and development server rejected all AJAX requests.
To fix the issue I did the following:
- Updated `server.js` to pass both GET and POST requests to the JobServer (`localhost:8081`)
- Changed all AJAX requests to use development HTTP server
- Added a helper function to build a correct URL for both dev and prod modes
Also, it seems that CoffeeScript and JavaScript code were out of sync in the `master`, so this PR contains a significant number of changes to `index.js`.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mushketyk/flink fix-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2431
----
commit 8b4ac3453bdae08c9f59594dfaf529026fa7e1d5
Author: Ivan Mushketyk <iv...@gmail.com>
Date: 2016-08-28T11:04:12Z
[FLINK-4521] Fix Submit panel in development mode
commit 406512b219738a721911f7709e532111c35e67fa
Author: Ivan Mushketyk <iv...@gmail.com>
Date: 2016-08-28T11:36:00Z
[FLINK-4521] Add utils.jobServerUrl helper method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
Hi @uce
I tried the latest version in the `master` branch and it seems that submit does not work there.
<img width="1677" alt="screen shot 2017-01-29 at 22 01 33" src="https://cloud.githubusercontent.com/assets/592286/22408446/eefd13c0-e670-11e6-9831-0fc6d3c7aaef.png">
I rebased my PR on top and tested it and it seems to work fine.
Are you sure that all issues with submit were fixed in current version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
Hi @uce,
No worries about the long delay. Just write here if you decide to merge it and I'll rebase it.
Best regards,
Ivan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2431
Sorry for the long delay with this one. The jar request URL has been fixed in another PR by now. This leaves the refactoring with the util instead of manually concatenating the URL. Should we change this @iampeter? I like it, but we would have to rebase this yet again as new requests have been added in the mean time. Sorry again for the long delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
Hi @iampeter
Thank you for your review and sorry for the long delay.
I'll update the code in the next few days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by iampeter <gi...@git.apache.org>.
Github user iampeter commented on the issue:
https://github.com/apache/flink/pull/2431
@mushketyk I suppose so, right @rmetzger ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
@rmetzger @iampeter I've rebased my PR on top of mainline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
Hi @iampeter
I've fixed the code according to your review.
Could you please review it again?
Best regards,
Ivan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2431
@rmetzger and @iampeter
What do you think about this pull request? Does this fit with the current Web UI efforts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by iampeter <gi...@git.apache.org>.
Github user iampeter commented on the issue:
https://github.com/apache/flink/pull/2431
@mushketyk looks good, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...
Posted by mushketyk <gi...@git.apache.org>.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2431
Hi @iampeter
Thank you for your review.
Do I need to rebase this PR to merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---