[GitHub] [incubator-kvrocks] ellutionist commented on a diff in pull request #1464: Fix flaky test in migration timeout

["ellutionist (via GitHub)" <gi...@apache.org>]

ellutionist commented on code in PR #1464:
URL: https://github.com/apache/incubator-kvrocks/pull/1464#discussion_r1202015912


##########
tests/gocase/integration/slotmigrate/slotmigrate_test.go:
##########
@@ -422,7 +422,7 @@ func TestSlotMigrateSync(t *testing.T) {
 		for _, timeout := range timeouts {
 			slot++
 			result := rdb0.Do(ctx, "clusterx", "migrate", slot, id1, "sync", timeout)
-			require.NoError(t, result.Err())
+			require.NoError(t, result.Err(), "without timeout: %v", timeout)

Review Comment:
   Should the message be "with timeout"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org