[GitHub] [zookeeper] Ghatage commented on a change in pull request #1498: ZOOKEEPER-2649 - Add more session and authentication information to S…

[GitBox <gi...@apache.org>]

Ghatage commented on a change in pull request #1498:
URL: https://github.com/apache/zookeeper/pull/1498#discussion_r504744421



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1599,8 +1599,11 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer) throws IOE
                 }
             }
             if (authReturn == KeeperException.Code.OK) {
+                ZooKeeperSaslServer saslServer = cnxn.zooKeeperSaslServer;
                 LOG.debug("Authentication succeeded for scheme: {}", scheme);
-                LOG.info("auth success {}", cnxn.getRemoteSocketAddress());
+                LOG.info("Session 0x{}: auth success for authorizationID={}/{}",
+                        Long.toHexString(cnxn.getSessionId()), saslServer.getAuthorizationID(),
+                        cnxn.getRemoteSocketAddress());

Review comment:
       That's right @ztzg.
   I was just helping clear out the backlog when I took this up but I think I'll need to add in more code so took a breather on this.
   I would still like to give it a shot till the weekend if you don't mind. Will tag you for updated codes' review :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org