You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/05/20 14:16:59 UTC

Review Request 21687: Add unit tests for mixins

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21687/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-5820
    https://issues.apache.org/jira/browse/AMBARI-5820


Repository: ambari


Description
-------

Cover the following files with unit tests:

mixins/common/chart/storm_linear_time.js
mixins/common/localStorage.js
mixins/main/host/details/host_components/decommissionable.js


Diffs
-----

  ambari-web/app/assets/test/tests.js ec8650e 
  ambari-web/test/mixins/common/chart/storm_linear_time_test.js PRE-CREATION 
  ambari-web/test/mixins/common/localStorage_test.js PRE-CREATION 
  ambari-web/test/mixins/main/host/details/host_components/decommissionable_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/21687/diff/


Testing
-------


Thanks,

Aleksandr Kovalenko

Re: Review Request 21687: Add unit tests for mixins

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21687/#review43476
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On May 20, 2014, 12:16 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21687/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 12:16 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-5820
>     https://issues.apache.org/jira/browse/AMBARI-5820
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cover the following files with unit tests:
> 
> mixins/common/chart/storm_linear_time.js
> mixins/common/localStorage.js
> mixins/main/host/details/host_components/decommissionable.js
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js ec8650e 
>   ambari-web/test/mixins/common/chart/storm_linear_time_test.js PRE-CREATION 
>   ambari-web/test/mixins/common/localStorage_test.js PRE-CREATION 
>   ambari-web/test/mixins/main/host/details/host_components/decommissionable_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21687/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>