[GitHub] [jmeter] FSchumacher commented on pull request #5876: Use JMeterProperty#intValue for loop count directly

["FSchumacher (via GitHub)" <gi...@apache.org>]

FSchumacher commented on PR #5876:
URL: https://github.com/apache/jmeter/pull/5876#issuecomment-1536374965

   I looked at `ThroughputController` and it is not easily fixed by using this approach, as it relies on a different default value.
   The `AbstractProperty#getFloatValue` catches `NumberFormatException`s and returns `0`. So, using it directly would lead to a different default value in case of a broken value.
   How did you search for those occurrences? I had to look a bit longer to find line 600 in JMSSampler, but there are surely more? Line 600 is a good candidate to replace, so I will extend this PR with it. Feel free, to push any changes, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org