You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2013/08/12 23:41:24 UTC
svn commit: r1513263 - in
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver:
IncreasingToUpperBoundRegionSplitPolicy.java RegionSplitPolicy.java
Author: stack
Date: Mon Aug 12 21:41:24 2013
New Revision: 1513263
URL: http://svn.apache.org/r1513263
Log:
HBASE-9189 IncreasingToUpperBoundRegionSplitPolicy.shouldSplit() should check all the stores before returning
Modified:
hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
Modified: hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java?rev=1513263&r1=1513262&r2=1513263&view=diff
==============================================================================
--- hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java (original)
+++ hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java Mon Aug 12 21:41:24 2013
@@ -80,7 +80,6 @@ extends ConstantSizeRegionSplitPolicy {
" size=" + size + ", sizeToCheck=" + sizeToCheck +
", regionsWithCommonTable=" + tableRegionsCount);
foundABigStore = true;
- break;
}
}
Modified: hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java?rev=1513263&r1=1513262&r2=1513263&view=diff
==============================================================================
--- hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java (original)
+++ hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java Mon Aug 12 21:41:24 2013
@@ -44,7 +44,7 @@ public abstract class RegionSplitPolicy
* The region configured for this split policy.
*/
protected HRegion region;
-
+
/**
* Upon construction, this method will be called with the region
* to be governed. It will be called once and only once.
@@ -54,7 +54,7 @@ public abstract class RegionSplitPolicy
this.region == null,
"Policy already configured for region {}",
this.region);
-
+
this.region = region;
}
@@ -85,7 +85,7 @@ public abstract class RegionSplitPolicy
largestStoreSize = storeSize;
}
}
-
+
return splitPointFromLargestStore;
}
@@ -98,14 +98,13 @@ public abstract class RegionSplitPolicy
*/
public static RegionSplitPolicy create(HRegion region,
Configuration conf) throws IOException {
-
Class<? extends RegionSplitPolicy> clazz = getSplitPolicyClass(
region.getTableDesc(), conf);
RegionSplitPolicy policy = ReflectionUtils.newInstance(clazz, conf);
policy.configureForRegion(region);
return policy;
}
-
+
static Class<? extends RegionSplitPolicy> getSplitPolicyClass(
HTableDescriptor htd, Configuration conf) throws IOException {
String className = htd.getRegionSplitPolicyClassName();
@@ -125,5 +124,4 @@ public abstract class RegionSplitPolicy
e);
}
}
-
}