You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2006/12/19 20:50:23 UTC
[jira] Created: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
---------------------------------------------------------------------------------------------------------
Key: LUCENE-754
URL: http://issues.apache.org/jira/browse/LUCENE-754
Project: Lucene - Java
Issue Type: Bug
Reporter: Yonik Seeley
Assigned To: Yonik Seeley
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=all ]
Yonik Seeley resolved LUCENE-754.
---------------------------------
Resolution: Fixed
patch committed.
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=all ]
Yonik Seeley updated LUCENE-754:
--------------------------------
Attachment: FieldCache.patch
typo in original (used reader instead of key)
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Oliver Hutchison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=comments#action_12459831 ]
Oliver Hutchison commented on LUCENE-754:
-----------------------------------------
Chuck and whoever else got burned by this - really big apology for letting that typo slip into my patch :-( Unfortunately because I was constrained to use a release version of Lucene I ended up implementing a different solution in our production system and obviously I didn't pick up the mistake I'd made in the patch.
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=comments#action_12459987 ]
Otis Gospodnetic commented on LUCENE-754:
-----------------------------------------
Since I was the one who first whined about this leak, I'm just following up to report that this change indeed eliminated the leak.
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Chuck Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=comments#action_12459791 ]
Chuck Williams commented on LUCENE-754:
---------------------------------------
This patch, together with LUCENE-750 (already committed) solved our problem completely. It sped up simultaneous multi-threaded searches with a new ParallelReader against a 1 million item investigation that has a unique id sort field (i.e., 1 million entry FIeldCache must be created) by a factor of 15x.
Thanks Yonik! +1 to commit this.
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-754) FieldCache keeps hard references to
readers, doesn't prevent multiple threads from creating same instance
Posted by "Chuck Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LUCENE-754?page=comments#action_12459763 ]
Chuck Williams commented on LUCENE-754:
---------------------------------------
Cool! This should solve at least part of my problem. Trying this now (along with finalizer removal patch that is already installed here). Will report back results.
Thanks!
> FieldCache keeps hard references to readers, doesn't prevent multiple threads from creating same instance
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-754
> URL: http://issues.apache.org/jira/browse/LUCENE-754
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assigned To: Yonik Seeley
> Attachments: FieldCache.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org