You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/27 23:34:12 UTC
[jira] [Commented] (S2GRAPH-63) Condition on partition strong edges
and weak edges on mutateEdges is wrong.
[ https://issues.apache.org/jira/browse/S2GRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304984#comment-15304984 ]
ASF GitHub Bot commented on S2GRAPH-63:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/49
[S2GRAPH-63]: Condition on partition strong edges and weak edges on mutateEdges is wrong.
condition to partition strongEdges and weakEdges are wrong.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-63
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 103965e3d198ed563f1b5ef4906c15659e52c468
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-05-27T23:32:47Z
[S2GRAPH-63]: Condition on partition strong edges and weak edges on mutateEdges is wrong.
----
> Condition on partition strong edges and weak edges on mutateEdges is wrong.
> ---------------------------------------------------------------------------
>
> Key: S2GRAPH-63
> URL: https://issues.apache.org/jira/browse/S2GRAPH-63
> Project: S2Graph
> Issue Type: Bug
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Labels: newbie, write
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Storage#mutateEdges use following condition to separate strong edges and weak edges.
> {noformat}
> val (strongEdges, weakEdges) =
> (edges.partition(e => e.label.consistencyLevel == "strong" || e.op == GraphUtil.operations("insertBulk")))
> {noformat}
> I think current condition is wrong. the condition should be following.
> {noformat}
> val (strongEdges, weakEdges) =
> (edges.partition(e => e.label.consistencyLevel == "strong" && e.op != GraphUtil.operations("insertBulk")
> {noformat}
> Because of above bug, insertBulk is not working as intended(not lookup snapshotEdge and just build and fire RPCs).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)