You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/02 13:28:47 UTC
[GitHub] [airflow] ashb opened a new pull request, #26131: Store datasets used for scheduling on the timetable, not the DAG
ashb opened a new pull request, #26131:
URL: https://github.com/apache/airflow/pull/26131
And as part of this, "tidy up" the API of BaseSerialization by making
(de)serialize a public method.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26131:
URL: https://github.com/apache/airflow/pull/26131#discussion_r961827166
##########
airflow/models/dag.py:
##########
@@ -2680,7 +2680,9 @@ class InletRef(NamedTuple):
outlet_datasets: Dict[Dataset, None] = {}
input_datasets: Dict[Dataset, None] = {}
for dag in dags:
- for dataset in dag.dataset_triggers:
+ if not isinstance(dag.timetable, DatasetTriggeredTimetable):
+ continue
Review Comment:
Whoops yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26131:
URL: https://github.com/apache/airflow/pull/26131#issuecomment-1235675959
I'm going to split this pr in two - the dataset out from the BaseSerialisation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #26131:
URL: https://github.com/apache/airflow/pull/26131#discussion_r961823320
##########
airflow/models/dag.py:
##########
@@ -2680,7 +2680,9 @@ class InletRef(NamedTuple):
outlet_datasets: Dict[Dataset, None] = {}
input_datasets: Dict[Dataset, None] = {}
for dag in dags:
- for dataset in dag.dataset_triggers:
+ if not isinstance(dag.timetable, DatasetTriggeredTimetable):
+ continue
Review Comment:
i think exiting here means you don't iterate through outlets to get outlet datasets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
URL: https://github.com/apache/airflow/pull/26131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #26131: Store datasets used for scheduling on the timetable, not the DAG
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #26131:
URL: https://github.com/apache/airflow/pull/26131#issuecomment-1287956530
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org