You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/21 22:16:34 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #10563: ARROW-13117: [R] Retain schema in new Expressions

ianmcook commented on a change in pull request #10563:
URL: https://github.com/apache/arrow/pull/10563#discussion_r655739346



##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -800,6 +808,21 @@ test_that("type checks with is_*()", {
   )
 })
 
+test_that("type checks on expressions", {
+  expect_dplyr_equal(
+    input %>%
+      transmute(
+        a = is.character(as.character(int)),

Review comment:
       Yes—this is a simplistic and somewhat contrived example of the motivating use case. For a more compelling version of it, see ARROW-12055: To make our translation of `is.na()` work consistently with base R, we will need to run different code depending on whether its input has a real number type, and we can't do that if we don't know the type.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org