You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "numinnex (via GitHub)" <gi...@apache.org> on 2026/08/17 11:46:03 UTC
[PR] refactor(sdk)!: remove v2 bridges and legacy message wire format [iggy]
numinnex opened a new pull request, #3904:
URL: https://github.com/apache/iggy/pull/3904
Removes the old bridge APIs such as `StoreConsumerOffset2` and `DeleteConsumerOffset2`, additionally promotes to the client side encoding the new message wire format, rather than relying on server-side conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sdk)!: remove v2 bridges and legacy message wire format [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3904:
URL: https://github.com/apache/iggy/pull/3904#issuecomment-5315788330
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.75%. Comparing base ([`aeee0fc`](https://app.codecov.io/gh/apache/iggy/commit/aeee0fc54420b30bf0a993776f539f80e9a2cd87?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`df46e91`](https://app.codecov.io/gh/apache/iggy/commit/df46e9146375a5a4a27432c4b403f5896c5f60f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3904 +/- ##
============================================
- Coverage 83.09% 82.75% -0.35%
+ Complexity 1339 1334 -5
============================================
Files 1217 1215 -2
Lines 165970 163975 -1995
Branches 134264 132487 -1777
============================================
- Hits 137915 135696 -2219
- Misses 24391 24640 +249
+ Partials 3664 3639 -25
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.74% <ø> (+0.11%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.19% <ø> (-0.37%)` | :arrow_down: |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.06% <ø> (-0.25%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.00% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.48% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.68% <100.00%> (-6.15%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3904/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.81% <ø> (-0.24%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/binary\_protocol/src/codes.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fcodes.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvZGVzLnJz) | `100.00% <ø> (ø)` | |
| [core/binary\_protocol/src/consensus/command.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Fcommand.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9jb21tYW5kLnJz) | `100.00% <ø> (ø)` | |
| [core/binary\_protocol/src/consensus/header.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Fheader.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9oZWFkZXIucnM=) | `82.86% <ø> (+1.30%)` | :arrow_up: |
| [core/binary\_protocol/src/consensus/operation.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Foperation.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9vcGVyYXRpb24ucnM=) | `97.41% <ø> (-0.17%)` | :arrow_down: |
| [core/binary\_protocol/src/dispatch.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fdispatch.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2Rpc3BhdGNoLnJz) | `91.23% <ø> (-1.71%)` | :arrow_down: |
| [core/binary\_protocol/src/framing.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fframing.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2ZyYW1pbmcucnM=) | `95.10% <ø> (+0.12%)` | :arrow_up: |
| [...equests/consumer\_offsets/delete\_consumer\_offset.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Frequests%2Fconsumer_offsets%2Fdelete_consumer_offset.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL3JlcXVlc3RzL2NvbnN1bWVyX29mZnNldHMvZGVsZXRlX2NvbnN1bWVyX29mZnNldC5ycw==) | `100.00% <ø> (ø)` | |
| [...requests/consumer\_offsets/store\_consumer\_offset.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Frequests%2Fconsumer_offsets%2Fstore_consumer_offset.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL3JlcXVlc3RzL2NvbnN1bWVyX29mZnNldHMvc3RvcmVfY29uc3VtZXJfb2Zmc2V0LnJz) | `100.00% <ø> (ø)` | |
| [...ry\_protocol/src/requests/messages/send\_messages.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Frequests%2Fmessages%2Fsend_messages.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL3JlcXVlc3RzL21lc3NhZ2VzL3NlbmRfbWVzc2FnZXMucnM=) | `100.00% <ø> (ø)` | |
| [...y\_protocol/src/responses/messages/poll\_messages.rs](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fresponses%2Fmessages%2Fpoll_messages.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL3Jlc3BvbnNlcy9tZXNzYWdlcy9wb2xsX21lc3NhZ2VzLnJz) | `97.29% <ø> (-1.60%)` | :arrow_down: |
| ... and [93 more](https://app.codecov.io/gh/apache/iggy/pull/3904?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [50 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sdk)!: remove v2 bridges and legacy message wire format [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3904:
URL: https://github.com/apache/iggy/pull/3904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org